Skip to content

Commit

Permalink
NEVER merge your own Pull Request on a Team Project. ALWAYS assign fo…
Browse files Browse the repository at this point in the history
…r someone else to review! see: #32
  • Loading branch information
nelsonic committed Jan 25, 2017
1 parent e5066b8 commit df7c181
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,10 @@ can determine the _order_ in which they need to be worked on.
+ ***test***
+ ***develop*** and
+ ***deliver***

+ Where ever possible/practical/relevant **include** the person who
**_originally_ created the story/issue** in the time estimation discussion.

+ For work in sprints, a **milestone** is added **at the sprint planning
session** to group the user stories with its relevant sprint;
this gives _everyone_ in the team a **_clear_ picture** of what is ***planned***.
Expand Down Expand Up @@ -428,7 +430,10 @@ which ***improves review speed***.

+ If you have the _permissions_ to do so,
**assign your pull request**
to someone for review.
to someone (_else_) for review.

+ ***Never*** merge your _own_ pull requests on a **_team_ project**.
**No Exceptions**. Just ***don't do it***.

A good example PR: https://github.com/indexzero/ps-tree/pull/12

Expand Down

0 comments on commit df7c181

Please sign in to comment.