Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-commit #409

Closed
ZooeyMiller opened this issue Oct 3, 2017 · 3 comments
Closed

Remove pre-commit #409

ZooeyMiller opened this issue Oct 3, 2017 · 3 comments
Labels
chore a tedious but necessary task often paying technical debt

Comments

@ZooeyMiller
Copy link
Contributor

Since this is no longer a node project, and has no package.json or node_modules, our precommit now errors when trying to commit: .git/hooks/pre-commit: line 2: ./node_modules/pre-commit/hook: No such file or directory.

This means every commit has to be run with --no-verify. I think we should just remove this pre-commit and add it in again if it becomes necessary.

@ZooeyMiller ZooeyMiller added the chore a tedious but necessary task often paying technical debt label Oct 3, 2017
@iteles
Copy link
Member

iteles commented Oct 4, 2017

@ZooeyMiller Though it might be worth considering adding a pa11y pre-commit hook once we have the server? What are your thoughts?

@ZooeyMiller
Copy link
Contributor Author

@iteles I would 100% agree. I do think that this only really makes sense once we have a server set up, and not for the current static GH pages site.

@ZooeyMiller
Copy link
Contributor Author

Couldn't see the pre-commit in the hook section on github, so I removed my local files and re-cloned, and the pre-commit hook was gone. @finnhodgkin isn't getting this either so this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt
Projects
None yet
Development

No branches or pull requests

2 participants