Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarwhal Website Lint Report for dwyl.com #450

Open
nelsonic opened this issue Apr 12, 2018 · 6 comments
Open

Sonarwhal Website Lint Report for dwyl.com #450

nelsonic opened this issue Apr 12, 2018 · 6 comments
Labels
bug Suspected or confirmed bug (defect) in the code chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment! technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

https://sonarwhal.com is an Open Source website scanning tool
that checks for asite's accessibility, speed and common errors.
see: https://github.com/sonarwhal/sonarwhal

image

The Scan for the dwyl.com website:
https://sonarwhal.com/scanner/17e38af9-0bb0-43f0-8d42-986c00151158
image

Reveals quite a few (86) errors ... 😞
@iteles what are your thoughts on addressing these?

@nelsonic nelsonic added bug Suspected or confirmed bug (defect) in the code help wanted If you can help make progress with this issue, please comment! chore a tedious but necessary task often paying technical debt technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Apr 12, 2018
@nelsonic nelsonic changed the title sonarwhal website lint report for dwyl.com (Spoiler Alert: it's not great!) Sonarwhal Website Lint Report for dwyl.com Apr 12, 2018
@iteles
Copy link
Member

iteles commented Apr 12, 2018

That's interesting. We have used other tools in the past that have apparently been more 'forgiving':

See #14 (comment) and
http://wave.webaim.org/report#/dwyl.com
screen shot 2018-04-12 at 22 27 47

Also, not being able to have links inside <li>s? I've never even heard of that as a thing.

@nelsonic
Copy link
Member Author

@iteles yeah, I was not aware of the no <a> in <li> "rule" either ... 🙄
I like the fact that Sonarwhal can be run on Continuous Integration (Travis-CI) 🔴 / ✅ ?
such that any update to the site will automatically be "rejected" if it fails to pass. ⛔️
Also, this goes way beyond Accessibility ... 🔓
And it's Open Source so we can inspect the code 🔍
if/when we need to understand the reason why something is failing ... 😉

@iteles
Copy link
Member

iteles commented Apr 13, 2018

Agreed! I had suggested we set up a pa11y pre-commit hook as a starter here: #409 (comment)

As you say, this goes much further.
I'd like to make sure there is research/tests to back up that particular 'rule' first though!

@sohilpandya
Copy link
Member

sohilpandya commented Apr 13, 2018

So I was lucky enough to see this one during the conference https://www.youtube.com/watch?v=O_OJfY4Jax4&feature=youtu.be

But we should share this video with everyone.

I don't think it's related to this issue in particular.

@iteles
Copy link
Member

iteles commented Apr 13, 2018

Oh I'm so glad there's a video of it @sohilpandya, thanks for sharing, the tweets from that session were FANTASTIC!

@nelsonic
Copy link
Member Author

https://sonarwhal.com/
image

Rebranded as https://webhint.io/
image

Still super on-board with this. https://github.com/webhintio/hint
Definitely going to need something like this for the new site: #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Suspected or confirmed bug (defect) in the code chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment! technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Development

No branches or pull requests

3 participants