Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility | Meeting WCAG 2.0 and section 508 #14

Closed
iteles opened this issue Jun 18, 2015 · 18 comments
Closed

Accessibility | Meeting WCAG 2.0 and section 508 #14

iteles opened this issue Jun 18, 2015 · 18 comments
Assignees
@iteles
Labels
priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished question A question needs to be answered before progress can be made on this issue T4h Time Estimate 4 Hours
Milestone
Sprint 3

Comments

@iteles
Copy link
Member

iteles commented Jun 18, 2015

No description provided.

@iteles
Copy link
Member Author

iteles commented Jan 18, 2016

A great post from @Charlotteis to help with this, mentioned in #83.
https://github.com/dwyl/dwyl.github.io/issues

@iteles iteles added the priority-1 Highest priority issue. This is costing us money every minute that passes. label Apr 13, 2016
@Cleop
Copy link
Member

Cleop commented Jun 15, 2017

@iteles -

@Cleop Cleop added the question A question needs to be answered before progress can be made on this issue label Jun 15, 2017
@iteles
Copy link
Member Author

iteles commented Jun 15, 2017

I'll settle for running the site through wave.webaim.org and having it pass with no errors and minimal alerts 😊
We probably need to do some looking into how closely wave follows WCAG 2.0

Note: ngrok could again come in handy for this whilst you're testing locally (#244 (comment))

@iteles iteles assigned Cleop and unassigned iteles Jun 15, 2017
@iteles iteles removed the question A question needs to be answered before progress can be made on this issue label Jun 15, 2017
@ghost ghost assigned iteles and unassigned Cleop Aug 23, 2017
@ghost ghost removed the priority-1 Highest priority issue. This is costing us money every minute that passes. label Aug 23, 2017
@ghost ghost added this to the Backlog milestone Aug 23, 2017
@ghost ghost added the question A question needs to be answered before progress can be made on this issue label Aug 23, 2017
@ghost
Copy link

ghost commented Aug 23, 2017

@iteles would you be able to provide a list of requirements (checkboxes) to close this issue?

@iteles
Copy link
Member Author

iteles commented Sep 4, 2017

https://www.wuhcag.com/wcag-checklist/

Tools like https://www.powermapper.com/products/sortsite/checks/accessibility-checks/ and http://wave.webaim.org/ should help check this.

@iteles iteles removed their assignment Sep 4, 2017
@ghost
Copy link

ghost commented Sep 5, 2017

@ghost ghost modified the milestones: Sprint 2, Backlog Sep 5, 2017
@ghost ghost added priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished and removed question A question needs to be answered before progress can be made on this issue labels Sep 5, 2017
@iteles
Copy link
Member Author

iteles commented Sep 13, 2017

This is going to throw up an error and needs to be fixed before we go live: 3aa6cf2#diff-d015ee2938b049b883af8932cc97a99bR58

@ghost
Copy link

ghost commented Sep 15, 2017

@iteles can you clarify what needs changing?

@iteles
Copy link
Member Author

iteles commented Sep 15, 2017

@markwilliamfirth Yes, sorry, href="#" is what will throw an accessibility error.

@ghost ghost modified the milestones: Sprint 2, Sprint 1, Post-deployment Sep 20, 2017
@ZooeyMiller
Copy link
Contributor

We can use pa11y to check the site for accessbility, it has WCAG2 standards built in, but has the different levels as well, are we looking for A, AA or AAA rating? More info on the differences between the levels in the stack overflow answer.

On AA we get errors for contrast ratios, on A we do not.

finnhodgkin added a commit that referenced this issue Sep 29, 2017
@finnhodgkin
removes fieldset and replaces with a div with the same margins #14
b912097
finnhodgkin added a commit that referenced this issue Sep 29, 2017
@finnhodgkin
fixes team page github and twitter icon accessibility #14
6d1ecb4
finnhodgkin added a commit that referenced this issue Sep 29, 2017
@finnhodgkin
removes fieldset from time-app #14
b36b79d
@finnhodgkin finnhodgkin mentioned this issue Sep 29, 2017
Merged
@ghost
Copy link

ghost commented Oct 2, 2017

@ZooeyMiller I just ran pa11y

npm install -g pa11y
pa11y http://dwyl.com

...and got this:

screen shot 2017-10-02 at 13 26 01

Do you get the same?

I think A is fine for now

@ZooeyMiller
Copy link
Contributor

@markwilliamfirth as standard it with run with AA. run pa11y --ignore "warning;notice" --standard WCAG2A http://dwyl.com to run A and ignore warnings. Passes for me!

@ghost
Copy link

ghost commented Oct 2, 2017

@ZooeyMiller 👍

pa11y --ignore "warning;notice" --standard WCAG2A http://dwyl.com

screen shot 2017-10-02 at 14 04 10

This passes! 🎉

Running through wave (http://wave.webaim.org/) we get:

screen shot 2017-10-02 at 14 05 28

Running through powermapper (https://www.powermapper.com/products/sortsite/checks/accessibility-checks/) we get:

screen shot 2017-10-02 at 14 06 14

screen shot 2017-10-02 at 14 06 22

@iteles I think meeting WCAG2 A is fine for now - what do you think?

@ghost ghost assigned iteles and unassigned ZooeyMiller and finnhodgkin Oct 2, 2017
@ghost ghost added the question A question needs to be answered before progress can be made on this issue label Oct 2, 2017
@ZooeyMiller
Copy link
Contributor

I'm going to look into fixing the accessibility issues you've mentioned in #14 (comment) Mark.

@ZooeyMiller ZooeyMiller added in-progress An issue or pull request that is being worked on by the assigned person and removed question A question needs to be answered before progress can be made on this issue labels Oct 4, 2017
@ZooeyMiller ZooeyMiller assigned ZooeyMiller and unassigned iteles Oct 4, 2017
@ZooeyMiller
Copy link
Contributor

ZooeyMiller commented Oct 4, 2017 •
edited
Loading

One issue from sortsite is:

Removing the underline from links makes it hard for color-blind users to see them.

Is this a compromise we want to make? It is listed as an "A" level error. Related to #394

@ghost
Copy link

ghost commented Oct 4, 2017

@ZooeyMiller let's have underline as a link convention for all text links in page text (not nav and footer links etc)

ZooeyMiller added a commit that referenced this issue Oct 4, 2017
@ZooeyMiller
adds text to burger menu label
d74afb0 
#14
ZooeyMiller added a commit that referenced this issue Oct 4, 2017
@ZooeyMiller
remove name attributes from a tags
5162c3a 
a tags aren't supposed to have name attrs so it confuses screen readers
#14
ZooeyMiller added a commit that referenced this issue Oct 4, 2017
@ZooeyMiller
changes non-semantic h1s to h2s #14
0295a2a
@ZooeyMiller ZooeyMiller mentioned this issue Oct 4, 2017
Merged
@ZooeyMiller
Copy link
Contributor

report - google chrome_044

No red accessibility errors (red is for "A" standard, orange for "AA"). The other issues are worth looking into, but aren't accessibility so not strictly relevant for this issue.

@ghost
Copy link

ghost commented Oct 4, 2017

@iteles are you happy with this level of accessibility? We can keep going but I think this is good enough for now

@ghost ghost unassigned ZooeyMiller Oct 4, 2017
@ZooeyMiller ZooeyMiller removed the in-progress An issue or pull request that is being worked on by the assigned person label Oct 4, 2017
@ghost ghost assigned iteles Oct 4, 2017
@ghost ghost added the question A question needs to be answered before progress can be made on this issue label Oct 4, 2017
@iteles iteles closed this as completed Feb 12, 2018
@iteles iteles mentioned this issue Apr 12, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iteles iteles

Labels
priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished question A question needs to be answered before progress can be made on this issue T4h Time Estimate 4 Hours
Projects
None yet
Milestone
Sprint 3
Development

No branches or pull requests
4 participants
@iteles @Cleop @ZooeyMiller @finnhodgkin