Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is 'blog' always highlighted? #431

Open
iteles opened this issue Oct 9, 2017 · 3 comments
Open

Why is 'blog' always highlighted? #431

iteles opened this issue Oct 9, 2017 · 3 comments
Labels
design help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished
Milestone
Sprint 3

Comments

@iteles
Copy link
Member

iteles commented Oct 9, 2017

Why is 'blog' in the nav always turquoise, no matter what page I'm on?

I keep thinking it's highlighting the page I'm looking at.

I would also suggest that until we actually have some content, we probably don't want to highlight the Blog link.

screen shot 2017-10-09 at 19 26 29
@iteles iteles added priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished question A question needs to be answered before progress can be made on this issue labels Oct 9, 2017
@ghost ghost added the design label Oct 10, 2017
@ghost ghost assigned harrygfox Oct 10, 2017
@ghost ghost added this to the Sprint 3 milestone Oct 10, 2017
@harrygfox
Copy link
Member

@iteles Just to differentiate it from the other types of links on the navbar.
If it's confusing it should go.

@harrygfox harrygfox assigned ghost and unassigned harrygfox Oct 13, 2017
@iteles
Copy link
Member Author

iteles commented Oct 13, 2017

Thanks for clarifying @harrygfox! Only confusing because we don't really have one yet! Let's change it now and change it back when we want to differentiate it 👍

@iteles iteles unassigned ghost Nov 9, 2017
@iteles iteles added help wanted If you can help make progress with this issue, please comment! and removed question A question needs to be answered before progress can be made on this issue labels Nov 9, 2017
@Rob-Rychs Rob-Rychs mentioned this issue Dec 4, 2017
Merged
@Rob-Rychs
Copy link
Contributor

half-solved this with my PR which removes the blog link highlighting...

Proposal to fix: create function to get the pathname with JS and match it to the correct menu link, then add class to highlight it

would this go in script.js?

or it's own menu-highlighter.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished
Projects
None yet
Milestone
Sprint 3
Development

No branches or pull requests
3 participants
@iteles @harrygfox @Rob-Rychs