changed blog link in nav to not always be highlighted, instead highli… #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght on link :hover and :target
|
Deployed my branch to netlify to test the a:target https://suspicious-raman-a5c987.netlify.com/ looks like the menu link isn't staying highlighted This PR only half solves the issue... |
|
because clicking the link navigates to the link which re-renders the whole page...duh One way I guess to solve is to get the pathname with JS, parse it to remove the root domain and then match it to the $(a.link).value() and add the .dwyl-mint class to it... |
nelsonic
approved these changes
Aug 12, 2018
There was a problem hiding this comment.
@Rob-Rychs thank you for taking the time to make these visual improvements. 🎉
Meta: merging this PR as it "LGTM". If undesired, can easily be reverted. 👍
|
@nelsonic thanks buddy 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #431
Hard to test if the :active works because of how live-server handles the links...
Maybe try deploying it to a test-server and if the issue isn't fixed just ignore this PR
Changed blog link in nav to not always be highlighted, instead highlight on link a:hover and a:target