Creates Community page #290
Conversation
Cleop
added
the
awaiting-review
|
@Cleop, a reviewer has been added to the pull request. Any questions, complaints, feedback, contributions? |
1 similar comment
|
@Cleop, a reviewer has been added to the pull request. Any questions, complaints, feedback, contributions? |
dwylbot
bot
added
awaiting-review
|
@Cleop, a reviewer has been added to the pull request. Any questions, complaints, feedback, contributions? |
|
lol @dwylbot[bot] |
ghost
mentioned this pull request
| @@ -0,0 +1,138 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
There was a problem hiding this comment.
I hadn't noticed before but we're missing the lang attribute - useful for screen readers.
https://www.w3.org/International/questions/qa-html-language-declarations#attributes
| <div class="dib-ns bg-white pt4 pa2 shadow-4 ml5-ns w-40-ns"> | ||
|
|
||
| <form id="gform" method="POST" class="tc tl-ns" action="https://script.google.com/macros/s/AKfycby5ZdD8HfCaz1tMVLw26qYQKEXkP8qdfwLek3TH_RYH3l1o1-Li/exec"> | ||
| <!-- change the form action to your script url --> |
There was a problem hiding this comment.
I think we don't need this comment tag any more 😊
| </nav> | ||
|
|
||
| <section class="pt5 pt4-ns"> | ||
| <img src="./img/common/community-cover.png" alt="dwyl community members github profile collage" class="w-100"/> |
There was a problem hiding this comment.
This image is pretty massive at 1.42MB, can we serve up a smaller version for m and mobile screens? These are the most likely to be on data or poor connections.
Either way, we should bring down the size of this image across the board, I suggest jpeg mini lite 👍
There was a problem hiding this comment.
where did the image come from...? 🤔
There was a problem hiding this comment.
@nelsonic I assume from the work you were doing over the weekend!
There was a problem hiding this comment.
right ... but how did it end up here...? 🙃
There was a problem hiding this comment.
Found it: #282 (comment) 😕
I already have a specific purpose for the output of my work and it's not this.
but i'm not going to "make a fuss" about it; that's what I get for making my output public.
| We have people contributing remotely to our open-source projects from | ||
| Angola, Argentina, Australia, Bali, Belgium, Brazil, Canada, China, | ||
| Colombia, Estonia, Kenya, New Zealand, The Netherlands, Portugal, South | ||
| Africa and the USA. |
There was a problem hiding this comment.
and more! Better to say 'countries like' instead of just these countries?
| <em>Thanks</em> for contacting us! We will get back to you soon!</h2> | ||
| </div> | ||
|
|
||
| <!-- Submit the Form to Google Using "AJAX" --> |
iteles
added
in-review
Creates community page #289: