Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#222 Adds tag manager #319

Merged
merged 1 commit into from
Sep 14, 2017
Merged

#222 Adds tag manager #319

merged 1 commit into from
Sep 14, 2017

Conversation

Cleop
Copy link
Member

@Cleop Cleop commented Sep 13, 2017

#222 Adds tag manager

@Cleop Cleop added the in-progress An issue or pull request that is being worked on by the assigned person label Sep 13, 2017
@Cleop Cleop self-assigned this Sep 13, 2017
@Cleop Cleop added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Sep 13, 2017
@Cleop Cleop requested a review from SimonLab September 13, 2017 16:58
@Cleop Cleop assigned SimonLab and unassigned Cleop Sep 13, 2017
@dwylbot
Copy link

dwylbot bot commented Sep 13, 2017

@Cleop, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot dwylbot bot added the awaiting-review An issue or pull request that needs to be reviewed label Sep 13, 2017
@iteles iteles added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Sep 14, 2017
iteles
iteles approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks @Cleop, merging in so you can deploy and test.

@iteles iteles merged commit c7c1f16 into master Sep 14, 2017
@iteles iteles deleted the google-analytics branch September 14, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

@SimonLab SimonLab Awaiting requested review from SimonLab

Assignees

@SimonLab SimonLab

Labels
in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cleop @iteles @SimonLab