Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds transparent, consistent favicons #386

Merged
2 commits merged into from
Sep 29, 2017
Merged

adds transparent, consistent favicons #386

2 commits merged into from
Sep 29, 2017

Conversation

ZooeyMiller
Copy link
Contributor

Adds consistent favicons, with a transparent background.
It'd be great if someone reviewing can pull this branch down and check it on their local machine (you'll have to use live-server so that the links work) because it all worked for me locally, but I don't trust favicons. 👀
Fix #329 #381

@ZooeyMiller ZooeyMiller added the awaiting-review An issue or pull request that needs to be reviewed label Sep 29, 2017
@ZooeyMiller ZooeyMiller requested review from iteles, a user and finnhodgkin September 29, 2017 12:05
@ZooeyMiller ZooeyMiller changed the title adds transparent, consistent favicons #329 #381 adds transparent, consistent favicons Sep 29, 2017
@dwylbot
Copy link

dwylbot bot commented Sep 29, 2017

@ZooeyMiller, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot dwylbot bot added the awaiting-review An issue or pull request that needs to be reviewed label Sep 29, 2017
@dwylbot
Copy link

dwylbot bot commented Sep 29, 2017

@ZooeyMiller, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

1 similar comment
@dwylbot
Copy link

dwylbot bot commented Sep 29, 2017

@ZooeyMiller, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot dwylbot bot added the awaiting-review An issue or pull request that needs to be reviewed label Sep 29, 2017
@ghost
Copy link

ghost commented Sep 29, 2017

@ZooeyMiller I pulled this down but for some reason it doesn't work for me

screen shot 2017-09-29 at 14 17 32

screen shot 2017-09-29 at 14 17 53

@ZooeyMiller ZooeyMiller added in-progress An issue or pull request that is being worked on by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Sep 29, 2017
@ZooeyMiller ZooeyMiller assigned ZooeyMiller and unassigned iteles, ghost and finnhodgkin Sep 29, 2017
@ZooeyMiller ZooeyMiller added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Sep 29, 2017
@ZooeyMiller ZooeyMiller assigned iteles, ghost and finnhodgkin and unassigned ZooeyMiller Sep 29, 2017
@ZooeyMiller
Copy link
Contributor Author

@markwilliamfirth should be working now! please check it out when you get a moment.

@ghost
Copy link

ghost commented Sep 29, 2017

@ZooeyMiller looks like there are conflicts?

screen shot 2017-09-29 at 15 07 51

screen shot 2017-09-29 at 15 08 06

Not sure what's wrong - maybe it's me? 😬

@ZooeyMiller
Copy link
Contributor Author

@markwilliamfirth I don't have any conflicts locally, and I just pulled the branch. It wasn't working for @finnhodgkin before and is now, maybe try pulling again, and maybe doing a hard reload?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! 😄

@ghost ghost merged commit 8f2e8c5 into master Sep 29, 2017
@ghost ghost deleted the favicons branch September 29, 2017 14:55
@jammur jammur unassigned ghost Dec 14, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants