Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makes link dim on hover #392

Merged
1 commit merged into from
Sep 29, 2017
Merged

makes link dim on hover #392

1 commit merged into from
Sep 29, 2017

Conversation

ZooeyMiller
Copy link
Contributor

Adds a dim on the link to the blog post on the /blog page on hover and focus, in an attempt to make the link more obvious.

#380

@ZooeyMiller ZooeyMiller added the awaiting-review An issue or pull request that needs to be reviewed label Sep 29, 2017
@ZooeyMiller ZooeyMiller assigned ghost and finnhodgkin Sep 29, 2017
@ZooeyMiller ZooeyMiller requested review from a user and finnhodgkin September 29, 2017 16:26
@dwylbot
Copy link

dwylbot bot commented Sep 29, 2017

@ZooeyMiller, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

1 similar comment
@dwylbot
Copy link

dwylbot bot commented Sep 29, 2017

@ZooeyMiller, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot dwylbot bot added the awaiting-review An issue or pull request that needs to be reviewed label Sep 29, 2017
ghost
ghost approved these changes Sep 29, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure why not

@ghost ghost merged commit 7eb2c63 into master Sep 29, 2017
@ghost ghost deleted the make-link-obvious branch September 29, 2017 16:58
@ghost ghost mentioned this pull request Sep 29, 2017
Closed
@jammur jammur unassigned ghost Dec 14, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnhodgkin finnhodgkin Awaiting requested review from finnhodgkin

Assignees

@finnhodgkin finnhodgkin

Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZooeyMiller @finnhodgkin