Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds custom 404 page #400

Merged
1 commit merged into from
Oct 2, 2017
Merged

adds custom 404 page #400

1 commit merged into from
Oct 2, 2017

Conversation

ZooeyMiller
Copy link
Contributor

@ZooeyMiller ZooeyMiller commented Oct 2, 2017 •
edited
Loading

Adds a custom 404 page, as per the invision designs. GH pages will serve a file called 404.html on 404s rather than their default, so this will work.

fix #313

@ZooeyMiller ZooeyMiller requested review from iteles, finnhodgkin and a user October 2, 2017 15:24
@ZooeyMiller ZooeyMiller added the awaiting-review An issue or pull request that needs to be reviewed label Oct 2, 2017
@dwylbot dwylbot bot added the awaiting-review An issue or pull request that needs to be reviewed label Oct 2, 2017
finnhodgkin
finnhodgkin approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@finnhodgkin finnhodgkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I really like the white nav on a white background. The invision designs do that for every white page and I think it gives the site a more designed feel.

Can't tell if it works as a 404 until it's merged in but otherwise 👍

@dwyl dwyl deleted a comment from dwylbot bot Oct 2, 2017
@dwyl dwyl deleted a comment from dwylbot bot Oct 2, 2017
@dwyl dwyl deleted a comment from dwylbot bot Oct 2, 2017
@ghost
Copy link

ghost commented Oct 2, 2017

Cool let's merge and see if it works live

@ghost ghost merged commit b16b9cf into master Oct 2, 2017
@ghost ghost deleted the custom-404 branch October 2, 2017 16:01
@jammur jammur unassigned ghost Dec 14, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnhodgkin finnhodgkin finnhodgkin approved these changes

@iteles iteles Awaiting requested review from iteles

Assignees

@iteles iteles

@finnhodgkin finnhodgkin

Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create styled 404 page
3 participants
@ZooeyMiller @finnhodgkin @iteles