Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Simon bio, #439

Merged
merged 1 commit into from
Dec 19, 2017
Merged

add Simon bio, #439

merged 1 commit into from
Dec 19, 2017

Conversation

SimonLab
Copy link
Member

add a short bio on my profile, ref: #288

@SimonLab SimonLab requested a review from rub1e December 18, 2017 22:33
@dwylbot dwylbot bot added the awaiting-review An issue or pull request that needs to be reviewed label Dec 18, 2017
@dwylbot
Copy link

dwylbot bot commented Dec 18, 2017

@SimonLab, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

nelsonic
nelsonic approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@rub1e
Copy link
Member

rub1e commented Dec 19, 2017

Good man @SimonLab ! I love how confident you are using foreign words mixed in with English 😉 I also am impressed how you've managed to write a bio without talking about yourself at all 😁

My only comment is - is it ok to have the npm debug log committed? If so I'll merge at once, just let me know 😄

iteles
iteles approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Way. I can't believe this actually happened ❤️

@rub1e
Copy link
Member

rub1e commented Dec 19, 2017

@iteles it's all in how you ask 😉

If someone lets me know about the npm debug log then I'll merge in due course 😄

@iteles
Copy link
Member

iteles commented Dec 19, 2017

@rub1e The npm debug log line is just Simon adding it to the .gitignore so that the log doesn't get uploaded to github, so all good, you can go ahead and merge!

@rub1e rub1e merged commit 98db5aa into master Dec 19, 2017
@rub1e
Copy link
Member

rub1e commented Dec 19, 2017

OMG I'm an idiot - ignore me 😞

@rub1e rub1e deleted the simon-bio branch December 19, 2017 09:37
@rub1e
Copy link
Member

rub1e commented Dec 19, 2017

Is it obvious I've been coding solo for quite a while now...? 😟

@rub1e rub1e removed the awaiting-review An issue or pull request that needs to be reviewed label Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

@nelsonic nelsonic nelsonic approved these changes

@rub1e rub1e Awaiting requested review from rub1e

Assignees

@rub1e rub1e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonLab @rub1e @iteles @nelsonic