Form request #28
Merged
Form request #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonic
reviewed
Sep 25, 2016
| <head> | ||
| <title>S3 Upload Demo</title> | ||
| // optional stylesheet | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/flat-ui/2.2.2/css/flat-ui.min.css"> |
There was a problem hiding this comment.
We really like the end result of Flat-UI. and for this demo it is good.
But that reminds me ... dwyl/learn-tachyons#1 😉
nelsonic
reviewed
Sep 25, 2016
| // link to image | ||
| var successMessage = document.createElement('h4') | ||
| successMessage.innerHTML = 'Image Successfully Uploaded at: ' | ||
| var link = `https://<your_bucket_name>.s3.amazonaws.com/${filename}` |
There was a problem hiding this comment.
could the AWS_S3_BUCKET_NAME be an environment variable returned by the server in the getCredentialsFromServer call?
|
@jackcarlisle looks good. sorry for delay in review. had it open and then totally got distracted... 😫 |
|
@nelsonic no problem! Yeah I want to have a crack at using nightwatch so I'll try and incorporate it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready for review
Task List #22