Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract selenium install logic to a module #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sergeon
Copy link

@Sergeon Sergeon commented Feb 3, 2017

Before all: thanks you for this cool repo. It helped me a lot configuring nightwatch in a real project 👍

Currently, the whole nightwatch.conf.js is set as a postinstall hook in package.json. But the only reason to do that -as far as I understand- is to ensure that selenium gets downloaded. This is pretty misleading since people just copypasting the configuration object from nightwatch.conf.js to their own config file as a template would not get the tests to run, since selenium would not be downloaded.

Also, this way is just more clear what the postinstall hook is about.

Since now both the config files and the selenium-install.js module need the BINPATH, constants were also refactored to a common module.

@Sergeon
Copy link
Author

Sergeon commented Feb 5, 2017

Soz! I checked for a contributing.md in this project, didn't know you guys have a global one. I'll check it and open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants