Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explanation for testing on travis #57

Merged
merged 7 commits into from
Mar 20, 2017
Merged

add explanation for testing on travis #57

merged 7 commits into from
Mar 20, 2017

Conversation

ritz078
Copy link
Contributor

@ritz078 ritz078 commented Mar 15, 2017 •
edited
Loading

closes #8

@JoseCage JoseCage requested a review from nelsonic March 16, 2017 03:59
@ritz078
Copy link
Contributor Author

ritz078 commented Mar 17, 2017

@nelsonic Any update on this ?

@nelsonic nelsonic self-assigned this Mar 20, 2017
nelsonic
nelsonic approved these changes Mar 20, 2017
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritz078 this is a great write-up of using Nightwatch on Travis-CI! thank you! 🎉

@nelsonic nelsonic merged commit 536dca0 into dwyl:master Mar 20, 2017
@ritz078 ritz078 deleted the feat-travis branch March 21, 2017 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPIKE Can we run the e2e tests on TravisCI (or other CI)?
2 participants
@ritz078 @nelsonic