Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing build test issue#71 #72

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Oct 20, 2017

fixes #71 (failing build due to URL change...)

@nelsonic
Copy link
Member Author

Tests pass:
image

And yet CodeShip reports them as failing... 🤣 / 😠

@nelsonic
Copy link
Member Author

nelsonic commented Oct 21, 2017

Zero indication of why there's an npm ERR! ...
both tests are clearly passing.

I feel like I'm pretty much done with Nightwatch at this point.
Back to writing Elm!!

@nelsonic
Copy link
Member Author

@iteles this test passes on localhost and there is no indication as to why it is failing on CodeShip. In the interest of making the tutorial useful again, please consider merging this PR so that people running it on their localhost will not see an error. thanks.

Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelsonic These tests are all passing locally for me too and I can't seem to figure out what's up with codeship.
Will be merging as per #72 (comment)

@iteles iteles merged commit e928312 into master Oct 30, 2017
@iteles iteles deleted the fix-failing-build-test-issue#71 branch October 30, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeShip Build Failing because of Change to dwyl github page ...
3 participants