Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How much should custom classes be avoided when using tachyons? #31

Open
Cleop opened this issue Jun 15, 2017 · 2 comments
Open

How much should custom classes be avoided when using tachyons? #31

Cleop opened this issue Jun 15, 2017 · 2 comments

Comments

@Cleop
Copy link
Member

Cleop commented Jun 15, 2017

I've been following designs from invision etc. and using tachyons to implement them. At times I will find that some of the tachyon sizing jumps don't quite fit what I'm trying to replicate as the increments are too large. This might be with font size or with widths for example.

I sometimes find myself deliberating and thinking - should I use the tachyons class and not match the design well or should I create a custom class?

I know this is a very subjective question but I was just wondering if anyone else had any thoughts / experiences with this? I don't want the designer to think I'm being negligent but at the same time, it's hard to know when sometimes there is some flexibility with these things....

@gabrielperales have you experienced this as I noticed your issue #24 ?

This has occurred a couple of times for me but it was: dwyl/dwyl-site#272 (comment) that inspired me to ask this question.

@mrmrs

@gabrielperales
Copy link
Member

Hi @Cleop!. Yes, I had also this issue. I'm trying to avoid custom classes as I can, but sometimes you have to.

I've been thinking a lot about which approach I should follow. I came up with the idea of having all the scaffolding of tachyons replicated on my project with the same file names, and each of those files just has to import the original one, then I can start overwriting tachyons with variables, fonts and classes, but you will need to have something to build your own version (a webpack or gulp script) ... I haven't done it yet, but I have to do it soon.

@Cleop
Copy link
Member Author

Cleop commented Jun 20, 2017

Nice, @gabrielperales, I think that sounds similar to an approach that @des-des was showing me he used the other day. Check out: https://github.com/des-des/tachyons-webpack-boilerplate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants