Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign: Increase the size of the dwyl heart on the navbar #272

Closed
1 task done
Cleop opened this issue Jun 15, 2017 · 1 comment
Closed
1 task done

Redesign: Increase the size of the dwyl heart on the navbar #272

Cleop opened this issue Jun 15, 2017 · 1 comment
Labels
enhancement New feature or enhancement of existing functionality please-test Please test the feature in Staging Environment and confirm it's working as expected. T25m Time Estimate 25 Minutes

Comments

@Cleop
Copy link
Member

Cleop commented Jun 15, 2017 •
edited
Loading

Following @nelsonic's feedback: #264 (comment)

  • Increase the size of the heart-tick logo on the navbar

This is something I had deliberated over myself due to the tachyons included sizes. Currently using w1 it looks as follows:
Mob

Desktop

OR
Using w2 on Mob

and on Desktop

But because the w1 seems too small and the w2 seems to big, I'll opt for a custom class to get closer to the size from invision.
@Cleop Cleop added enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes labels Jun 15, 2017
@Cleop Cleop mentioned this issue Jun 15, 2017
Open
@Cleop Cleop self-assigned this Jun 19, 2017
@Cleop Cleop added in-progress An issue or pull request that is being worked on by the assigned person awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jun 19, 2017
Cleop added a commit that referenced this issue Jun 19, 2017
@Cleop
Resizes dwyl nav heart, #272
3a0d452
@Cleop Cleop mentioned this issue Jun 19, 2017
Merged
@Cleop Cleop added the please-test Please test the feature in Staging Environment and confirm it's working as expected. label Jun 19, 2017
@Cleop Cleop assigned ghost and unassigned Cleop Jun 19, 2017
@Cleop Cleop removed the awaiting-review An issue or pull request that needs to be reviewed label Jun 19, 2017
@ghost
Copy link

ghost commented Jun 21, 2017

Tested 👍

@ghost ghost closed this as completed Jun 21, 2017
@jammur jammur unassigned ghost Dec 14, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or enhancement of existing functionality please-test Please test the feature in Staging Environment and confirm it's working as expected. T25m Time Estimate 25 Minutes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cleop