Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: List Interface #400

Open
5 of 7 tasks
Tracked by #165
nelsonic opened this issue Aug 12, 2023 · 8 comments
Open
5 of 7 tasks
Tracked by #165

Epic: List Interface #400

nelsonic opened this issue Aug 12, 2023 · 8 comments
Labels
discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. priority-1 Highest priority issue. This is costing us money every minute that passes. technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Aug 12, 2023

With #345 we've added lists as outlined in #356
Documented in: book/mvp/lists
What we don't yet have is the interface for interacting with lists!

Todo

  • Clarify what benefits/features lists give us; we just need a brief sentence. 💡 📝
  • View/Manage existing lists including: 👀
    • Edit the text to change the display name of the list.

    Note: We need to decide if the "All" list should be re-nameable ... 💭

  • Create new lists 🆕
  • Move a item to a list. ➡️
    d2) Move multiple items to a list in a single action e.g: select multiple.
  • Remove an item from a list Feat: implement remove_item_from_list/3 function #422
  • Share a list with other people ... 🫂

Some of these features are already started in @SimonLab's Lists PR: #165
So my plan is to use that PR as the basis for this to not waste any work. 🤔

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. technical A technical issue that requires understanding of the code, infrastructure or dependencies priority-1 Highest priority issue. This is costing us money every minute that passes. discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code labels Aug 12, 2023
@nelsonic nelsonic pinned this issue Aug 12, 2023
@nelsonic nelsonic mentioned this issue Sep 7, 2023
10 tasks
nelsonic added a commit that referenced this issue Sep 10, 2023
@nelsonic
Copy link
Member Author

At present this is what we see when we visit http://localhost:4000/lists in the MVP on the items-list branch: #165
image

Similar to #396 this interface/layout needs some TLC. 🪄

@nelsonic
Copy link
Member Author

I don't think the "all" list should be editable/delete-able. 💭
If anyone disagrees, please comment. 🙏 💬

@LuchoTurtle
Copy link
Member

LuchoTurtle commented Sep 10, 2023

Don't disagree. It makes sense always to exist and it's a fundamental "view" on all items. 👌

@iteles
Copy link
Member

iteles commented Sep 10, 2023

If by editable you mean allow people to add or remove items from it, I agree it shouldn't be editable. It's the master list.

What I do think should exist is an option for a person to select whichever view they want as their 'home' view. I will open a separate issue for discussion as it doesn't impact this one.

@nelsonic
Copy link
Member Author

Working on the layout with TailwindUI:

image

Just need to tidy the buttons for Edit and Delete and then we can ship this initial version.
Note: we still need to work on how to add/move an item to list: #420

@nelsonic
Copy link
Member Author

Buttons themed: http://localhost:4000/lists

image

iOS Simulator:

image

Delete displays a Dialog prompt:
image

Note: this is not a Modal.
It's a contextual confirmation

Looks/works fine on Mobile because it's a Safari/Chrome standard feature:

image

Very happy for anyone else to suggest/improve the intro copy. 📝 🙏

Recommended reading: https://www.nngroup.com/articles/ok-cancel-or-cancel-ok/

nelsonic added a commit that referenced this issue Sep 15, 2023
@nelsonic nelsonic moved this to 🏗 In progress in dwyl app kanban Sep 15, 2023
@nelsonic
Copy link
Member Author

Tackling the "New List" Page next: http://localhost:4000/lists/new
image

@nelsonic
Copy link
Member Author

New list form with basic styling:

image

Also applies to the Edit page:

image

Added Created and Last Updated columns for additional info:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. priority-1 Highest priority issue. This is costing us money every minute that passes. technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Status: In progress
Status: 🏗 In progress
Development

No branches or pull requests

3 participants