Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix row chat message layout in README.md code section #50

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

FranckKe
Copy link

This has already been fixed in the file itself as #18 but not in the readme section.
Copy pasting the suggested code create the same row layout as the issue describe.
image

This pull request change the css to be closer to the original file
image

Modifications on chat inputs is are bit verbose, I can remove it to be cleaner to copy/paste.

Thanks for this tutorial 👍

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FranckKe great catch! 🔍
Thanks very much for fixing the README.md. 🙌
Glad you found the tutorial useful. 🚀

@nelsonic
Copy link
Member

Travis CI build Queued ... https://travis-ci.org/github/dwyl/phoenix-chat-example/builds/756296312
image

Given that this is a copy change, I'm going to merge it without CI. ✅
We might need to migrate to GitHub Actions at some point in any case ... dwyl/learn-phoenix#141

@nelsonic nelsonic merged commit e62fda4 into dwyl:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants