-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to phoenix 1.6 issue #61 [Part 2] #62
Conversation
…"true". See: #54 for auth
Note: Travis-CI is temporarily suspended, see: #55 (comment) related to: dwyl/learn-travis#67 Thanks for reviewing/merging. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 only exception is that I am getting the following error in my logs, and the image isn't loading in:
[debug] ** (Phoenix.Router.NoRouteError) no route found for GET /images/phoenix.png (ChatWeb.Router)
All the tests pass and the message functionality works though, so something may have just gone wrong in my environment. If you think the problem is localized I'm good to merge, for now I am going to approve of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
I don't have any log errors on my side.
@ajmeese7 maybe you can try to rebuild the app to see if it fixes the log on your side?
@ajmeese7 you may need to run |
Building on the work done by @ajmeese7 in #61 ("Part 1") to update to this tutorial/repo to Phoenix 1.6,
this PR:
/assets/
directory.Follows the instructions in Chris McCord's guide #55 (comment)
Aaron had already done most of the work to upgrade. 🙌
This tidy up was only required for anyone who had the older version of the project on their
localhost
. 🙄