Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret key base #19

Merged
merged 4 commits into from
Dec 2, 2018
Merged

Secret key base #19

merged 4 commits into from
Dec 2, 2018

Conversation

RobStallion
Copy link
Member

@RobStallion RobStallion commented Dec 2, 2018

update config file so that it uses secret key from the .env file. Was using the default one previously.
update test config to use a 'default' secret key
update readme to reflect changes to config files
#17

@RobStallion RobStallion requested a review from nelsonic December 2, 2018 16:52
@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #19   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines          61     61           
=====================================
  Hits           61     61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213f8b3...55cb997. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobStallion looks great! thanks! 👍

@nelsonic nelsonic merged commit 09c0a24 into master Dec 2, 2018
@nelsonic nelsonic deleted the secret_key_base branch December 2, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants