Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper function is private #10

Closed
th0mas opened this issue Sep 18, 2020 · 2 comments · Fixed by #11
Closed

Helper function is private #10

th0mas opened this issue Sep 18, 2020 · 2 comments · Fixed by #11
Assignees
@th0mas
Labels
priority-2 T25m

Comments

@th0mas
Copy link
Collaborator

th0mas commented Sep 18, 2020

transform_roles_string_to_list_of_ints/1 is a private function as when reviewing #7 I believed this would only be used internally, however this would be a useful function to have when persisting roles to a database.
@th0mas th0mas self-assigned this Sep 18, 2020
@th0mas
Copy link
Collaborator Author

th0mas commented Sep 18, 2020

@nelsonic Are you happy to rename this function to parse_role_string to save on keypresses?

@th0mas th0mas mentioned this issue Sep 18, 2020
Merged
@nelsonic
Copy link
Member

nelsonic commented Sep 19, 2020 •
edited
Loading

@th0mas your IDE should autocomplete the function name, 💭
but that function name makes sense so feel free to update it. 👍

nelsonic added a commit that referenced this issue Sep 19, 2020
@nelsonic
Merge pull request #11 from dwyl/10-unprivate-helper-func
62de8db 
#10: Unprivate helper function
nelsonic added a commit that referenced this issue Sep 19, 2020
@nelsonic
version bump package (0.5.0 -> 0.5.1) to publish parse_role_string/1 #10
df41176 
 / #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@th0mas th0mas

Labels
priority-2 T25m
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#10: Unprivate helper function dwyl/rbac
2 participants
@nelsonic @th0mas