Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added progressbar stories + fixes #736

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Added progressbar stories + fixes #736

merged 1 commit into from
Apr 6, 2022

Conversation

aidamag
Copy link
Contributor

@aidamag aidamag commented Mar 2, 2022

Fixes:

  • If no label, the value was in the left part instead of the right. Now it is placed always on the right.
  • If showValue=true and no value, the progressbar should be determinate and with value=0.

Fixes:
- If no label, the value was in the right part instead of the left. Now it is placed always on the left.
- If showValue=true and no value, the progressbar should be determinate and with value=0
@aidamag aidamag linked an issue Mar 2, 2022 that may be closed by this pull request
@Jialecl Jialecl self-requested a review March 25, 2022 11:40
@Jialecl Jialecl self-assigned this Mar 25, 2022
@Jialecl Jialecl merged commit 8ff63aa into master Apr 6, 2022
@Jialecl Jialecl deleted the fix-651 branch April 6, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visual regression tests for ProgressBar component
2 participants