-
Notifications
You must be signed in to change notification settings - Fork 18
Added virtualization to DxcSelect
#2243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mil4n0r
wants to merge
13
commits into
master
Choose a base branch
from
Mil4n0r/virtualization_select
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Mil4n0r/virtualization_select
…logy/halstack-react into Mil4n0r/virtualization_select
Some quick notes:
|
…o Mil4n0r/virtualization_select
…logy/halstack-react into Mil4n0r/virtualization_select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/lib
directory./website
as needed.Our select was not behaving properly with huge datasets due to performance issues (overloading the DOM and doing data processing).
In order to get around that problem, there is a common strategy, virtualization, which allows the component to load only a few items at once and update that list of items each time an user scrolls over it.
I have implemented it using
virtuoso
, one of the highest performance libraries out there that remains up to date and can achieve all the common use cases for these kind of strategies.The work is still in progress, however, there are a few limitations that we have to take into account:
// TODO
in the code.DxcPaginator
menus, which don't allow switching pages smoothly when there is a big amount of them.DxcResultsetTable
component with a simpler logic which could be useful to understand howvirtuoso
works in an easier way.