Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle URL #28

Closed
genfersee opened this issue Feb 2, 2020 · 27 comments
Closed

Toggle URL #28

genfersee opened this issue Feb 2, 2020 · 27 comments

Comments

@genfersee
Copy link

Hello,

I have some Somfy blinds. Would it be possible you add some parameter to enter a « toggle_url »? Then I could avoid to install an extra plugin to add buttons for toggle url.

Thanks in advance!
@dxdc
Copy link
Owner

dxdc commented Feb 3, 2020

Not sure I understand why this would be needed @genfersee ?

Maybe you can describe your use case a bit better. I don't see an issue putting the same URL for both up and down if you only have a toggle option?

Your suggestion gets very complicated though because up and down are not exactly how the blinds work on HomeKit. It just requests a value 0-100 for blind position... so what happens with toggle if the value is 50? Anyway, let me know your thoughts.

@genfersee
Copy link
Author

genfersee commented Feb 3, 2020 •
edited
Loading

Hi @dxdc ! :)
Well in fact, my Somfy blinds has 4 command urls:

  • 1 for up,
  • 1 for down
  • 1 for stop
  • 1 for toggle

The toggle command sends the contrary of the last command send:

  • If the blind is already down and you push toggle, the blind will go up
  • If the blind is already up and you push toggle, the blind will go down
  • If the blind is moving down and you push toggle, it will change direction and move up
  • If the blind is moving up and you push toggle, it will change direction and move down

My usecase is that I have a programmable homekit stateless button. I want to link the toggle URL to this button to have:

  • 1 press and blind is going up
  • 1 press and blind is going down
  • 1 press and blind is going up

Hope it helps :):)
Thanks in advance!

@dxdc
Copy link
Owner

dxdc commented Feb 3, 2020

Maybe I'm missing something, but doesn't Homekit already do this? Just click on the blinds button.

1 press and blind is going up
1 press and blind is going down
1 press and blind is going up

Thinking about this some more though, if this feature was added, it won't work with your approach unless the plugin creates this stateless button (similar to the stateless 'stop' button that can be optionally exposed).

So, then you are proposing it would just track whatever the last command is and send the opposite, right?

@dxdc
Copy link
Owner

dxdc commented Feb 3, 2020

So, then you are proposing it would just track whatever the last command is and send the opposite, right?

Or, would it send the toggle_url you have provided? I guess either way, the button needs to be exposed by this plugin.

@genfersee
Copy link
Author

genfersee commented Feb 3, 2020 •
edited
Loading

So, then you are proposing it would just track whatever the last command is and send the opposite, right?

Yes, exactly like the secondary stop button: your plugin would create another secondary toggle button, calling the toggle url we would define in config.json.

Then,

Maybe I'm missing something, but doesn't Homekit already do this? Just click on the blinds button.

When setting some action for my stateless programmable button in Homekit interface, I have to set an accessory. Currently, I can only choose "blind up", "blind down" or "blind stop". But I need this "blind toggle" secondary button...

@dxdc
Copy link
Owner

dxdc commented Feb 4, 2020

I meant, why is a toggle button even needed? Isn't the "built-in toggle" of up/down with the existing Homekit button sufficient? Or, is there some other use you're proposing?

@genfersee
Copy link
Author

Let me show you the interface I have to setup my stateless programmable button.
As you can see in picture below, I need to define the accessories to be called when button is pressed.

So what I would need is a toggle button as shown below (currently made via another plugin).
The point is that if I use your plugin, I can only set "blind up", "blind down" or "blind stop", whereas I need "blind toggle".

Hope it helps :)

pic

@dxdc
Copy link
Owner

dxdc commented Feb 10, 2020

@genfersee I had some time to think about this idea. I realized there is a fundamental problem with the described concept that conflicts with the nature of the plugin.

If we expose a button for a separate toggle URL, the plugin will completely lose track of the blind position. Because, we have no knowledge whether the toggle URL will be taking the blinds up or down. This will disrupt the position of the blinds within HomeKit. Furthermore, the other standard functionality (sending stop commands, etc.) wouldn't be available.

So, an alternate approach would be to expose a button and let the plugin decide whether to send the up or down command. This could be done by recording which command was sent last (up or down) and sending the opposite command. I'm not sure how popular of an idea this would be though or if it would fit your use case.

I think the functionality you're after might be best implemented within Node-RED. There are several HomeKit plugins for Node-RED that I think would allow you to take advantage of the functionality you're looking for and design the correct logic for your use case. For example, you could create a switch that would either send the "up" or "down" command to the blinds based on their current position, time of day, etc.

@genfersee
Copy link
Author

Thanks for your answer! I understand the design issue.
The alternate solution you propose would indeed work great for me since I am exclusively using your plugin to control my blinds!

dxdc added a commit that referenced this issue Feb 10, 2020
@dxdc
Add 'toggle button' feature; #28
e044eda
dxdc added a commit that referenced this issue Feb 10, 2020
@dxdc
Additional changes for #28
39d331f
@dxdc
Copy link
Owner

dxdc commented Feb 10, 2020

@genfersee OK, I've enabled this feature. Hopefully it will be useful to you!

Please see the instructions. Essentially, you'll need to do the following:

  1. sudo npm -g install homebridge-blinds@1.3.10
  2. Add show_toggle_button: true to your config.json for each blinds you want to add a toggle button for.
  3. Restart homebridge

Please give it a try and let me know your feedback.

@genfersee
Copy link
Author

genfersee commented Feb 10, 2020 •
edited
Loading

Hi @dxdc,

I have just installed the 1.3.10, and configured config.json as follow:
I also added defines a toggle url in the config, maybe I did not use the correct syntax?

    {
        "accessory": "BlindsHTTP",
        "name": "Bureau Sud",
        "up_url": "http://192.168.33.xx/control?cmd=up,typ,som,did,yyy,aid,22,acmd,1,seq,3,smk,0,1&id=22",
        "down_url": "http://192.168.33.xx/control?cmd=down,typ,som,did,yyy,aid,22,acmd,0,seq,3,smk,0,0&id=22",
        "stop_url": "http://192.168.33.xx/control?cmd=my,typ,som,did,yyy,aid,22,acmd,3,seq,3&id=22",
        "toggle_url": "http://192.168.33.xx/control?cmd=my,typ,som,did,yyy,aid,22,acmd,3,seq,3&id=22",
        "show_stop_button": true,
        "show_toggle_button": true,
        "motion_time": "36000",
        "http_method": "POST",
        "trigger_stop_at_boundaries": false
    },

I have the following error logs:

[2020-2-10 7:39:40 PM] Error: Cannot add a Service with the same UUID '00000049-0000-1000-8000-0026BB765291' as another Service in this Accessory without also defining a unique 'subtype' property.
at Accessory.addService (/usr/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/Accessory.js:152:15)
at /usr/lib/node_modules/homebridge/lib/server.js:471:19
at Array.forEach ()
at Server._createAccessory (/usr/lib/node_modules/homebridge/lib/server.js:451:14)
at Server._loadAccessories (/usr/lib/node_modules/homebridge/lib/server.js:309:26)
at Server.run (/usr/lib/node_modules/homebridge/lib/server.js:91:38)
at module.exports (/usr/lib/node_modules/homebridge/lib/cli.js:59:10)
at Object. (/usr/lib/node_modules/homebridge/bin/homebridge:17:22)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
at startup (internal/bootstrap/node.js:283:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
[2020-2-10 7:39:40 PM] Got SIGTERM, shutting down Homebridge...

@dxdc
Copy link
Owner

dxdc commented Feb 10, 2020

Hmm. I didn't test the stop and toggle buttons together. Maybe some minor issue there, will correct it. In the meantime, try disabling the stop button and just testing the toggle functionality:

"show_stop_button": false,

@dxdc
Copy link
Owner

dxdc commented Feb 10, 2020

@genfersee Just added the missing subtype (I believe). Try: sudo npm -g install homebridge-blinds@1.3.11 as per above.

@genfersee
Copy link
Author

@dxdc,
Much better! Now it is working! Thanks you so much, I can not get rid of the extra plugin I was using to create the toggle switches ;)

@genfersee
Copy link
Author

genfersee commented Feb 10, 2020 •
edited
Loading

I see now a small issue:
After a few up and down, if for example the blind is set as "closed" in Home app, and I tap on toggle button to open it, then the state of the blind on the main icon is inconsistent:

  • it is marked as "closed" while the blind is going up
  • After the blind is physically up, the state of the main blind icon shows "closing" instead of "opening" and remains in that state forever

@dxdc
Copy link
Owner

dxdc commented Feb 10, 2020

@genfersee I made a number of minor changes to the code that I'm hoping will help with stability within HomeKit and reflecting the correct values. I also changed the way the toggle functionality works that I think is superior.

Please update again and test.

@genfersee
Copy link
Author

@dxdc this works really great now! I always get a consistent state in main blind icon!
Thanks you very much!

I noticed however a strange behavior:
If blind is up or down, and you set it to go at 59% for example, then you can see that the plugin is generating a huge bunch of lines in the logs, several per seconds:

[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:03 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:04 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:05 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:06 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:07 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)
[2020-2-11 8:04:08 AM] [Bureau Sud] End Move down (to 59%)

@genfersee
Copy link
Author

genfersee commented Feb 11, 2020 •
edited
Loading

After a whole reboot of the Pi, I see a strange issue. Before restarting it, when I tested, everything was going ok (except the log I sent just before). Now, when I press either the main blind button, the stop button or the toggle button, they all remains in "ON" state forever until I tap a second time on them. Before, the stop and toggle button were returning to "OFF" state right after tapping, and the blind main icon was waiting for move duration timetout to change state, which was correct. Now this does not work anymore.

For example: case where blind is up, blind main icon is showing "ON" and "up", stop and toggle icons are "OFF".
I tap on stop button, it remains in "ON" position forever. If I leave iOS Home app to main icons screen and then go back in Home app, then we can see that the stop button gets properly reset to "OFF" position.
In the logs, not a lot to see:
[2020-2-11 8:27:57 AM] [Bureau Sud] Requesting manual stop
[2020-2-11 8:27:57 AM] [Bureau Sud] Stop request sent

I restarted homebridge process and it works fine.
I rebooted the Pi and it still works fine....
So the issue may not be caused by reboot and not easily reproducable.

... but issue from my previous post is still present ;)

@dxdc
Copy link
Owner

dxdc commented Feb 11, 2020

@genfersee I saw these issues too and believe I've rectified them. This includes this issue, which I have seen too:

For example: case where blind is up, blind main icon is showing "ON" and "up", stop and toggle icons are "OFF".

I'm still waiting for some additional testing on another issue, but for now, you can download/manually patch your version for now if you like and report back! I'm hoping I can push this as a new release this week. Appreciate your reporting.

https://raw.githubusercontent.com/zwerch/homebridge-blinds/master/index.js

@genfersee
Copy link
Author

@dxdc I won't have access to the Pi today, so I will wait your next official release!

@dxdc
Copy link
Owner

dxdc commented Feb 14, 2020

Released. Please open a new issue if you still experience issues.

@dxdc dxdc closed this as completed Feb 14, 2020
@genfersee
Copy link
Author

@dxdc Thnks for this major release, I will test it over the weekend and let you know!

@genfersee
Copy link
Author

Hi @dxdc! After some testing, everything seems to be fixed and works properly, this is really great, thank you so much for your help!

@genfersee
Copy link
Author

... and I will be glad to offer you a beer if you have a Paypal account! ;-)

@dxdc
Copy link
Owner

dxdc commented Feb 17, 2020

Sure that would be appreciated! :) You could send it here..

@genfersee
Copy link
Author

@dxdc sent! Thanks again for this custom development!

@dxdc
Copy link
Owner

dxdc commented Feb 17, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dxdc @genfersee