Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fork of Audited gem #55

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Use fork of Audited gem #55

merged 1 commit into from
Nov 6, 2019

Conversation

james
Copy link
Contributor

@james james commented Nov 5, 2019

We had two bugs with the audited gem, and I've opened PRs for both of them:

collectiveidea/audited#522
collectiveidea/audited#523

In the meantime, while we're waiting for them to hopefully be approved and merged, I have created my own fork with a branch that has both of those changes in.

This means that we no longer need the monkey pathes in the dwelling and development models. Also update the specs to reflect the new, fixed error messages.

We had two bugs with the audited gem, and I've opened PRs for both of them:

collectiveidea/audited#522
collectiveidea/audited#523

In the meantime, while we're waiting for them to hopefully be approved and merged, I have created my own fork with a branch that has both of those changes in.

This means that we no longer need the monkey pathes in the dwelling and development models. Also update the specs to reflect the new, fixed error messages.
@james james requested a review from gazaston November 5, 2019 14:35
@james
Copy link
Contributor Author

james commented Nov 5, 2019

@james james merged commit 36f3040 into develop Nov 6, 2019
@james james deleted the fix/forked-audited-gem branch November 6, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants