Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overly permissive regexs #1235

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix overly permissive regexs #1235

merged 1 commit into from
Jan 18, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Jan 18, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented Jan 18, 2024

Walkthrough

The update across various service adapters introduces stricter validation for video IDs by implementing case-sensitive regular expressions. These regex patterns now only accept uppercase letters, standardizing the format for video IDs and potentially improving consistency and security in the fetchVideoInfo method.

Changes

Files Change Summary
.../dailymotion.ts, .../googledrive.ts, .../youtube.ts Enforced uppercase-only video ID validation in regex checks within fetchVideoInfo.

🐇✨
In the land of code, where the wild regex roams,
A rabbit hopped in, setting uppercase tones.
No small letters in sight, only caps lock keys,
Video IDs stand tall, as tall as the trees. 🌳🔠

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 51c598c and a0194a1.
Files selected for processing (3)
  • server/services/dailymotion.ts (1 hunks)
  • server/services/googledrive.ts (1 hunks)
  • server/services/youtube.ts (1 hunks)

server/services/dailymotion.ts Show resolved Hide resolved
server/services/googledrive.ts Show resolved Hide resolved
server/services/youtube.ts Show resolved Hide resolved
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06b4a6c) 61.5597% compared to head (a0194a1) 61.4251%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1235        +/-   ##
================================================
- Coverage   61.5597%   61.4251%   -0.1347%     
================================================
  Files           117        117                
  Lines          9412       9501        +89     
  Branches       1156       1155         -1     
================================================
+ Hits           5794       5836        +42     
- Misses         3618       3665        +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 18, 2024

Passing run #837 ↗︎

0 71 1 0 Flakiness 0

Details:

Merge a0194a1 into 51c598c...
Project: OpenTogetherTube Commit: 51016d7da6 ℹ️
Status: Passed Duration: 03:53 💡
Started: Jan 18, 2024 2:11 PM Ended: Jan 18, 2024 2:15 PM

Review all test suite changes for PR #1235 ↗︎

@dyc3 dyc3 merged commit 827543b into master Jan 18, 2024
18 checks passed
@dyc3 dyc3 deleted the regex-fix branch January 18, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant