vis: refactor zoom code into a reusable useD3Zoom hook

[dyc3]

No description provided.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dyc3]

• vis: TopologyView: surround regions with bounding boxes #1615
• vis: TopologyView: group subtrees by region #1614
• vis: TopologyView: accept node radius props #1613
• vis: refactor zoom code into a reusable useD3Zoom hook #1612 👈
• vis: TopologyView: color things correctly with color provider #1611
• vis: TopologyView: render radial subtrees #1610
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 61.3260%. Comparing base (69c7e46) to head (0cfeb91).

Files	Patch %	Lines
packages/ott-vis-panel/src/chartutils.ts	11.1111%	16 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1612        +/-   ##
================================================
- Coverage   61.3624%   61.3260%   -0.0365%     
================================================
  Files           169        170         +1     
  Lines         24823      24841        +18     
  Branches       1458       1460         +2     
================================================
+ Hits          15232      15234         +2     
- Misses         9535       9551        +16     
  Partials         56         56                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cypress]

Passing run #1536 ↗︎

0

79

1

0

0

Details:

Merge 0cfeb91 into 69c7e46...
Project: OpenTogetherTube	Commit: 2132b3acfd ℹ️
Status: Passed	Duration: 05:24 💡
Started: Apr 4, 2024 9:38 PM	Ended: Apr 4, 2024 9:43 PM

Review all test suite changes for PR #1612 ↗︎

[dyc3]

Merge activity

• Apr 4, 5:36 PM EDT: @dyc3 started a stack merge that includes this pull request via Graphite.
• Apr 4, 5:37 PM EDT: Graphite rebased this pull request as part of a merge.
• Apr 4, 5:42 PM EDT: Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected.

[cypress]

Passing run #1537 ↗︎

0

79

1

0

0

Details:

vis: refactor zoom code into a reusable `useD3Zoom` hook (#1612)
Project: OpenTogetherTube	Commit: e5913502e9
Status: Passed	Duration: 05:01 💡
Started: Apr 4, 2024 9:59 PM	Ended: Apr 4, 2024 10:04 PM

Review all test suite changes for PR #1612 ↗︎