Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Fix web3-utils version #128

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fix web3-utils version #128

merged 1 commit into from
Jan 30, 2019

Conversation

AntonioJuliano
Copy link
Member

They made a breaking change to web3 / web3-utils in 1.0.0-beta.38 and didn't mark it as a breaking change in semver 😡

@AntonioJuliano
Copy link
Member Author

causing things like this: https://circleci.com/gh/dydxprotocol/bidder/686?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@AntonioJuliano
Copy link
Member Author

AntonioJuliano commented Jan 30, 2019 •
edited
Loading

See things like: web3/web3.js#2270

web3/web3.js#2267

web3/web3.js#2268

@AntonioJuliano AntonioJuliano merged commit ccd9da2 into master Jan 30, 2019
@AntonioJuliano AntonioJuliano deleted the antonio-3 branch January 30, 2019 23:21
@nivida
Copy link

nivida commented Jan 31, 2019

They made a breaking change to web3 / web3-utils in 1.0.0-beta.38 and didn't mark it as a breaking change in semver 😡

Sorry for the troubles will fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prettymuchbryce prettymuchbryce prettymuchbryce approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntonioJuliano @nivida @prettymuchbryce