comments

dydxprotocol · Mar 5, 2024 · 414c5be · 414c5be
1 parent f25d8c7
commit 414c5be
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/protocol/streaming/grpc/grpc_streaming_manager.go b/protocol/streaming/grpc/grpc_streaming_manager.go
@@ -17,7 +17,7 @@ type GrpcStreamingManagerImpl struct {
 
 	// orderbookSubscriptions maps subscription IDs to their respective orderbook subscriptions.
 	orderbookSubscriptions map[uint32]*OrderbookSubscription
-	nextId                 uint32
+	nextSubscriptionId     uint32
 }
 
 // OrderbookSubscription represents a active subscription to the orderbook updates stream.
@@ -59,8 +59,8 @@ func (sm *GrpcStreamingManagerImpl) Subscribe(
 	sm.Lock()
 	defer sm.Unlock()
 
-	sm.orderbookSubscriptions[sm.nextId] = subscription
-	sm.nextId++
+	sm.orderbookSubscriptions[sm.nextSubscriptionId] = subscription
+	sm.nextSubscriptionId++
 
 	return nil
 }
@@ -112,6 +112,7 @@ func (sm *GrpcStreamingManagerImpl) SendOrderbookUpdates(
 	}
 
 	// Clean up subscriptions that have been closed.
+	// If a Send update has failed for any clob pair id, the whole subscription will be removed.
 	for _, id := range idsToRemove {
 		delete(sm.orderbookSubscriptions, id)
 	}

diff --git a/protocol/x/clob/types/errors.go b/protocol/x/clob/types/errors.go
@@ -519,6 +519,7 @@ var (
 		"Subaccount cannot open more orders due to equity tier limit.",
 	)
 
+	// GrpcStreamingManager errors.
 	ErrGrpcStreamingManagerNotEnabled = errorsmod.Register(
 		ModuleName,
 		11000,