[TRA-108] Add market type to indexer events. #1201
Conversation
WalkthroughThe changes primarily focus on integrating a new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
protocol/indexer/events/events.pb.gois excluded by:!**/*.pb.goprotocol/indexer/protocol/v1/types/perpetual.pb.gois excluded by:!**/*.pb.go
Files selected for processing (21)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/bundle.ts (4 hunks)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts (7 hunks)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/protocol/v1/perpetual.ts (1 hunks)
- indexer/packages/v4-protos/src/codegen/gogoproto/bundle.ts (1 hunks)
- indexer/packages/v4-protos/src/codegen/google/bundle.ts (1 hunks)
- proto/dydxprotocol/indexer/events/events.proto (2 hunks)
- proto/dydxprotocol/indexer/protocol/v1/perpetual.proto (1 hunks)
- protocol/indexer/events/perpetual_market_create.go (3 hunks)
- protocol/indexer/events/perpetual_market_create_test.go (3 hunks)
- protocol/indexer/protocol/v1/v1_mappers.go (2 hunks)
- protocol/indexer/protocol/v1/v1_mappers_test.go (2 hunks)
- protocol/testutil/keeper/clob.go (1 hunks)
- protocol/x/clob/keeper/clob_pair.go (2 hunks)
- protocol/x/clob/keeper/clob_pair_test.go (8 hunks)
- protocol/x/clob/keeper/deleveraging_test.go (2 hunks)
- protocol/x/clob/keeper/get_price_premium_test.go (1 hunks)
- protocol/x/clob/keeper/liquidations_test.go (8 hunks)
- protocol/x/clob/keeper/msg_server_create_clob_pair_test.go (2 hunks)
- protocol/x/clob/keeper/msg_server_place_order_test.go (2 hunks)
- protocol/x/clob/keeper/orders_test.go (5 hunks)
- protocol/x/clob/keeper/process_operations_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- indexer/packages/v4-protos/src/codegen/gogoproto/bundle.ts
Additional comments: 37
indexer/packages/v4-protos/src/codegen/google/bundle.ts (1)
- 1-14: The import statements and namespace exports in
bundle.tsare correctly structured and follow best practices for organizing and exporting namespaces in TypeScript. This change enhances the modularity and readability of the code by clearly separating concerns and providing a structured way to accessapiandprotobufrelated functionalities under theproto/dydxprotocol/indexer/protocol/v1/perpetual.proto (1)
- 8-17: The
PerpetualMarketTypeenum inperpetual.protois well-defined, with clear and descriptive names for each market type. This addition will allow for more precise representation and handling of different perpetual market types in the system, enhancing the protocol's flexibility and functionality.protocol/indexer/events/perpetual_market_create_test.go (2)
- 8-8: Adding the
perptypesimport is necessary for accessing thePerpetualMarketTypeenum values in the test. This change correctly aligns with the modifications made to the perpetual market creation event to include themarketTypeattribute.- 25-25: Updating the
MarketTypefield assignment to usev1types.PerpetualMarketType_PERPETUAL_MARKET_TYPE_CROSSfrom theperptypespackage in the test function is correct. This ensures that the test reflects the new functionality introduced by adding themarketTypeattribute to perpetual market creation events.protocol/indexer/events/perpetual_market_create.go (2)
- 5-6: Renaming the imported package to
clobtypesand adding theperptypesimport are appropriate changes that improve code clarity and enable the use of thePerpetualMarketTypeenum in theNewPerpetualMarketCreateEventfunction.- 16-22: The addition of the
marketTypeparameter of typePerpetualMarketTypefrom theperptypespackage to theNewPerpetualMarketCreateEventfunction is a necessary change to support the new functionality of distinguishing between different types of perpetual markets. This change is correctly implemented and enhances the protocol's capabilities.indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/protocol/v1/perpetual.ts (1)
- 1-67: The TypeScript enums
PerpetualMarketTypeandPerpetualMarketTypeSDKType, along with the conversion functionsperpetualMarketTypeFromJSONandperpetualMarketTypeToJSON, are correctly defined and implemented. These changes facilitate the handling of perpetual market types in the TypeScript codebase, ensuring consistency and ease of use when working with these values.protocol/x/clob/keeper/msg_server_create_clob_pair_test.go (2)
- 6-6: The addition of the
libimport is necessary for the test setup, ensuring that the test has access to required functionalities from thelibpackage. This change is appropriate and supports the test's requirements.- 66-66: Including
testPerp1.Params.MarketTypein the function call within theTestCreateClobPairfunction is a correct update that reflects the new functionality of handling different perpetual market types. This ensures that the test accurately tests the system's behavior with the addition of themarketTypeattribute.protocol/indexer/protocol/v1/v1_mappers.go (1)
- 193-207: The addition of the
ConvertToPerpetualMarketTypefunction inv1_mappers.gois a necessary and well-implemented change that facilitates the conversion of perpetual market types between different versions. This function enhances the system's flexibility and interoperability by allowing for seamless conversion of market types, ensuring compatibility across different parts of the system.protocol/x/clob/keeper/get_price_premium_test.go (1)
- 186-186: Adding
perpetual.Params.MarketTypeas a parameter in the function call within theTestGetPricePremiumForPerpetualfunction is a correct and necessary update. This change ensures that the test accurately reflects the system's behavior with the introduction of themarketTypeattribute, testing the system's ability to handle different perpetual market types.protocol/testutil/keeper/clob.go (1)
- 291-291: The addition of the
MarketTypeparameter to theNewPerpetualMarketCreateEventfunction call is correctly implemented. This change aligns with the PR's objective to enhance market creation events with more detailed information, specifically distinguishing between different types of perpetual markets. It's important to ensure that all downstream functions and event handlers that consume this event are updated accordingly to handle the newMarketTypeattribute.indexer/packages/v4-protos/src/codegen/dydxprotocol/bundle.ts (1)
- 49-175: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [52-326]
The reordering of imports and updating of paths in
bundle.tsimproves code organization and readability. It's important to verify that these changes do not introduce any breaking changes or issues with dependencies within the project. Ensuring that all references to these modules are updated accordingly will help maintain the integrity of the codebase.Verification successful
The reordering of imports and updating of paths in
bundle.tshave been successfully verified. The references to the updated modules by their aliases (_56 and _57) are correctly implemented within thebundle.tsfile, and there's no indication of issues or misreferences based on the executed scripts. It's still recommended to ensure comprehensive testing to verify the overall integrity of the project.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that updated import paths are correctly referenced throughout the project. rg --type ts "./indexer/protocol/v1/perpetual" "./indexer/protocol/v1/subaccount"Length of output: 152
Script:
#!/bin/bash # Adjusting the search strategy to find references to the updated modules by their aliases. rg --type ts "_56" --files-with-matches rg --type ts "_57" --files-with-matchesLength of output: 203
protocol/x/clob/keeper/msg_server_place_order_test.go (2)
- 179-179: The addition of the
MarketTypeparameter to theNewPerpetualMarketCreateEventfunction call within theTestPlaceOrder_Errortest setup is correctly implemented. This change ensures that the test reflects the updated event structure and aligns with the PR's objective to enhance market creation events. It's important to verify that the test logic correctly handles the newMarketTypeattribute and that all related tests are updated accordingly.- 324-324: The inclusion of the
MarketTypeparameter in theNewPerpetualMarketCreateEventfunction call within theTestPlaceOrder_Successtest setup is correctly implemented. This ensures consistency with the updated event structure and the PR's objectives. As with other tests, it's crucial to ensure that theMarketTypeattribute is correctly handled in the test logic and that any related tests are also updated to reflect these changes.protocol/indexer/protocol/v1/v1_mappers_test.go (2)
- 12-12: The addition of the
perptypespackage import is necessary for the new test functionTestConvertToPerpetualMarketTypeto function correctly.- 432-475: The new test function
TestConvertToPerpetualMarketTypecorrectly tests the conversion ofPerpetualMarketTypetov1.PerpetualMarketType. It includes a comprehensive set of test cases, covering all definedPerpetualMarketTypevalues, and correctly handles thePERPETUAL_MARKET_TYPE_UNSPECIFIEDcase by expecting a panic. This thorough approach ensures that the conversion function behaves as expected across all valid inputs and fails gracefully on invalid inputs.proto/dydxprotocol/indexer/events/events.proto (2)
- 8-8: The addition of the import statement for
dydxprotocol/indexer/protocol/v1/perpetual.protois necessary to use thePerpetualMarketTypeenum in thePerpetualMarketCreateEventV1message.- 356-358: The addition of the
marketTypefield to thePerpetualMarketCreateEventV1message is correctly implemented. It uses thePerpetualMarketTypeenum from the newly importedperpetual.proto, allowing for the distinction between different types of perpetual markets. This change aligns with the PR objectives to enhance perpetual market creation events with more detailed information. It's also correctly positioned at the end of the message to maintain backward compatibility.protocol/x/clob/keeper/clob_pair.go (1)
- 108-108: The addition of
perpetual.Params.MarketTypeto theNewPerpetualMarketCreateEventfunction call withinCreatePerpetualClobPaireffectively integrates the newmarketTypeattribute into the perpetual market creation events. This change aligns with the PR's objective to enhance event data sent to the indexer by distinguishing between different types of perpetual markets.Ensure that the
marketTypeattribute is correctly documented in the protobuf definitions and that all downstream systems consuming these events are updated to handle the new attribute appropriately.protocol/x/clob/keeper/clob_pair_test.go (8)
- 69-69: The addition of
MarketTypeto theNewPerpetualMarketCreateEventfunction call aligns with the PR objectives to enhance perpetual market creation events. This change ensures that theMarketTypeinformation is included in the event data, which is crucial for distinguishing between different types of perpetual markets.- 191-191: Similar to the previous comment, the inclusion of
MarketTypein theNewPerpetualMarketCreateEventfunction call here is consistent with the PR's goal of enhancing the detail provided in perpetual market creation events. This ensures that the indexer receives comprehensive information about the market being created.- 283-283: The addition of
MarketTypein this context is crucial for ensuring that the test accurately reflects the changes made to the perpetual market creation event structure. By includingMarketType, the test validates that the new attribute is correctly processed and mapped within the system.- 436-436: Including
MarketTypein theNewPerpetualMarketCreateEventfunction call within this test case is essential for verifying that the system correctly handles the new attribute in various scenarios. This change is a direct reflection of the PR's objectives to enhance the detail and accuracy of perpetual market creation events.- 628-628: The inclusion of
MarketTypein theNewPerpetualMarketCreateEventfunction call here is necessary for ensuring that the final settlement process for a CLOB pair correctly includes theMarketTypeinformation. This aligns with the PR's goal of enhancing the detail provided in perpetual market creation events.- 745-745: The addition of
MarketTypein this test case is important for validating the system's ability to handle valid status transitions for CLOB pairs, including the newMarketTypeattribute. This ensures that the system correctly processes and maps theMarketTypeinformation during CLOB pair status updates.- 803-803: Including
MarketTypein theNewPerpetualMarketCreateEventfunction call within this test case is crucial for testing the system's handling of unsupported status transitions for CLOB pairs. This addition ensures that theMarketTypeattribute is considered in various status transition scenarios.- 841-841: The inclusion of
MarketTypein theNewPerpetualMarketCreateEventfunction call here is necessary for testing the system's response to unsupported status transitions to unsupported statuses. This ensures that theMarketTypeattribute is correctly handled in all status transition scenarios.protocol/x/clob/keeper/deleveraging_test.go (2)
- 416-416: The addition of the
MarketTypeparameter in theNewPerpetualMarketCreateEventfunction call ensures that the market type information is correctly passed and utilized. This change aligns with the PR's objective to enhance perpetual market creation events with the addition of theMarketTypeattribute.- 790-790: Similar to the previous comment, the addition of the
MarketTypeparameter in theNewPerpetualMarketCreateEventfunction call within theTestOffsetSubaccountPerpetualPositiontest function is consistent with the PR's objective. This ensures that the market type information is correctly incorporated into the event creation process.indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts (2)
- 849-851: The addition of the
marketTypeattribute to thePerpetualMarketCreateEventV1interface is correctly implemented and aligns with the PR objectives to enhance perpetual market creation events. The use of thePerpetualMarketTypeenum for this attribute is appropriate and consistent with the rest of the file.- 922-924: The addition of the
marketTypeattribute to thePerpetualMarketCreateEventV1SDKTypeinterface is correctly implemented and aligns with the PR objectives to enhance perpetual market creation events. The use of thePerpetualMarketTypeSDKTypeenum for this attribute is appropriate and consistent with the rest of the file.protocol/x/clob/keeper/orders_test.go (5)
- 1044-1050: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [14-1047]
The test function
TestPlaceShortTermOrdercovers a wide range of scenarios for placing short-term orders. It's well-structured and uses table-driven tests to ensure various conditions are tested. However, there are a few areas where improvements can be made:
- Error Handling: Ensure that all error paths are tested. For example, tests for invalid inputs that could lead to runtime errors should be included if not already covered.
- Code Duplication: There's a noticeable pattern of setup code that is repeated across sub-tests. Consider refactoring this setup code into helper functions to reduce duplication and improve maintainability.
- Test Coverage: Verify that all critical paths and edge cases are covered. This includes testing for boundary conditions, potential race conditions, and any special cases that might affect the order placement logic.
Overall, the test function appears to be comprehensive, but ensure that the above points are addressed to improve the quality and maintainability of the tests.
- 1099-1105: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1048-1102]
The test
TestPlaceShortTermOrder_PanicsOnStatefulOrdercorrectly verifies that the system panics when a stateful order is passed to a function intended for short-term orders. This is a good practice to ensure that the system behaves as expected in error conditions. However, consider adding a comment explaining why this behavior is expected and the importance of ensuring that stateful orders are not mistakenly treated as short-term orders. This will help future maintainers understand the rationale behind this test case.
- 1854-1860: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1103-1857]
The test function
TestAddPreexistingStatefulOrderthoroughly tests the addition of preexisting stateful orders, including various scenarios and edge cases. A few suggestions for improvement:
- Clarity and Documentation: Some of the test cases are complex and involve multiple steps and conditions. Adding comments or documentation within the test cases to explain the setup and expected outcomes can greatly improve readability and maintainability.
- Error Handling and Edge Cases: Ensure comprehensive coverage of error handling paths and edge cases. This includes testing for invalid order states, incorrect order types, and any other conditions that could lead to unexpected behavior.
- Refactoring for Reusability: If there's common setup code or assertions that are repeated across test cases, consider refactoring them into helper functions. This can reduce duplication and make the tests easier to update in the future.
Overall, the test function is well-structured and covers a broad range of scenarios, but the above refinements can enhance its clarity and effectiveness.
- 2068-2074: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1858-2071]
The test
TestPlaceOrder_SendOffchainMessageseffectively verifies that offchain messages are sent as expected during order placement. It's a good practice to mock external dependencies, like the indexer event manager, to isolate the system under test. However, consider the following improvements:
- Mock Verification: Ensure that the mock expectations are verified at the end of the test. This includes checking that all expected calls to the mocked indexer event manager were made with the correct parameters.
- Error Scenarios: If applicable, add tests for scenarios where sending offchain messages might fail or behave unexpectedly. This can help ensure robust error handling in the system.
- Documentation: Adding comments to explain the purpose of the test and the significance of sending offchain messages in this context can help future maintainers understand the test's intent.
By addressing these points, the test can be made more comprehensive and maintainable.
- 2200-2206: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [2072-2203]
The test
TestPerformStatefulOrderValidation_PreExistingStatefulOrderchecks the validation logic for preexisting stateful orders. It's crucial for ensuring the integrity of the system's state. A few points to consider:
- Comprehensive Coverage: Make sure that all relevant scenarios are tested, including cases where orders might be partially filled, canceled, or otherwise modified before validation.
- Error Handling: Test how the system handles errors or inconsistencies in the state of preexisting orders. This includes situations where the order data might be corrupted or incomplete.
- Documentation: Given the importance of stateful order validation, adding detailed comments or documentation to explain the test setup, expected behavior, and significance of each test case can be very helpful for future maintainers.
Enhancing the test with these considerations can improve its effectiveness in verifying the system's behavior.
| @@ -2261,6 +2261,7 @@ func setupProcessProposerOperationsTestCase( | |||
| clobPair.SubticksPerTick, | |||
| clobPair.StepBaseQuantums, | |||
| tc.perpetuals[perpetualId].Params.LiquidityTier, | |||
| tc.perpetuals[perpetualId].Params.MarketType, | |||
There was a problem hiding this comment.
The line seems to be a stray line number without corresponding code. This could be a typographical error or misplaced comment. Please review and remove or correct it as necessary.
The line seems to be a stray line number without corresponding code. This could be a typographical error or misplaced comment. Please review and remove or correct it as necessary.
The line seems to be a stray line number without corresponding code. This could be a typographical error or misplaced comment. Please review and remove or correct it as necessary.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (2)
- indexer/services/ender/tests/helpers/constants.ts (2 hunks)
- protocol/x/clob/abci_test.go (2 hunks)
Additional comments: 5
indexer/services/ender/__tests__/helpers/constants.ts (2)
- 27-27: The import of
PerpetualMarketTypeis correctly added to support the newmarketTypeattribute in perpetual market creation events. Good job on maintaining the import order and consistency.- 142-142: Initialization of
marketTypewithPerpetualMarketType.PERPETUAL_MARKET_TYPE_CROSSindefaultPerpetualMarketCreateEventis correctly implemented. Ensure that this default value aligns with the expected behavior in tests and does not inadvertently affect test outcomes.protocol/x/clob/abci_test.go (3)
- 712-718: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1085-1085]
The test
TestPrepareCheckState_WithProcessProposerMatchesEventsWithBadBlockHeightcorrectly verifies the panic behavior when the block height does not match, ensuring robust error handling.
- 712-718: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1185-1185]
The test
TestBeginBlocker_Successeffectively verifies theBeginBlockerfunction's behavior in initializingProcessProposerMatchesEventsfor the next block, ensuring correct state management.
- 712-718: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1235-1235]
The test
TestPrepareCheckStateprovides comprehensive coverage of thePrepareCheckStatefunction under various scenarios, including a regression case, ensuring robust functionality and state management.
| @@ -712,6 +712,7 @@ func TestEndBlocker_Success(t *testing.T) { | |||
| constants.ClobPair_Btc.SubticksPerTick, | |||
| constants.ClobPair_Btc.StepBaseQuantums, | |||
| constants.BtcUsd_20PercentInitial_10PercentMaintenance.Params.LiquidityTier, | |||
| constants.BtcUsd_20PercentInitial_10PercentMaintenance.Params.MarketType, | |||
There was a problem hiding this comment.
The market type for the ETH perpetual market creation event is incorrectly set to the BTC market type.
- constants.BtcUsd_20PercentInitial_10PercentMaintenance.Params.MarketType,
+ constants.EthUsd_20PercentInitial_10PercentMaintenance.Params.MarketType,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| constants.BtcUsd_20PercentInitial_10PercentMaintenance.Params.MarketType, | |
| constants.EthUsd_20PercentInitial_10PercentMaintenance.Params.MarketType, |
| constants.ClobPair_Btc.SubticksPerTick, | ||
| constants.ClobPair_Btc.StepBaseQuantums, | ||
| constants.BtcUsd_20PercentInitial_10PercentMaintenance.Params.LiquidityTier, | ||
| constants.BtcUsd_20PercentInitial_10PercentMaintenance.Params.MarketType, | ||
| ), | ||
| ), | ||
| ).Once().Return() |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1035-1035]
The test TestLiquidateSubaccounts contains commented-out assertions related to the liquidation process, indicating incomplete test coverage.
Please complete the test coverage to ensure the liquidation process is correctly verified.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1135-1135]
The test TestCommitBlocker_WithProcessProposerMatchesEventsWithBadBlockHeight mistakenly calls PrepareCheckState instead of CommitBlocker, leading to a duplicate test of PrepareCheckState.
Please correct the function call to accurately test the intended CommitBlocker behavior.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
protocol/indexer/events/events.pb.gois excluded by:!**/*.pb.go
Files selected for processing (3)
- proto/dydxprotocol/indexer/events/events.proto (2 hunks)
- protocol/x/clob/genesis_test.go (2 hunks)
- protocol/x/clob/module_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- proto/dydxprotocol/indexer/events/events.proto
Additional comments: 3
protocol/x/clob/genesis_test.go (2)
- 6-7: The addition of
cosmossdk.io/errorsimport is appropriate for enhanced error handling in the test cases.- 460-460: The addition of the
perpetual.Params.MarketTypeparameter in the function call is crucial for testing the newmarketTypeattribute functionality. It's important to ensure that tests are updated to cover new functionalities introduced in the codebase.protocol/x/clob/module_test.go (1)
- 309-309: The addition of the
MarketTypeparameter in theTestAppModule_InitExportGenesisfunction is essential for ensuring comprehensive test coverage for the newmarketTypeattribute functionality. It's important to maintain thorough tests for new features introduced in the codebase.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts (7 hunks)
Files skipped from review as they are similar to previous changes (1)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
protocol/indexer/protocol/v1/types/perpetual.pb.gois excluded by:!**/*.pb.go
Files selected for processing (1)
- proto/dydxprotocol/indexer/protocol/v1/perpetual.proto (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- proto/dydxprotocol/indexer/protocol/v1/perpetual.proto
vincentwschau
deleted the
vincentc/tra-108-add-market-type-indexer-events
branch
Changelist
Add perpetual market type to perpetual market creation event sent from protocol to indexer.
Test Plan
Unit tests.
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.