Remove volatile market #1263
Merged
Remove volatile market #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe recent updates involve modifications to both the development and staging testnet scripts. Specifically, the use of test volatile markets has been disabled in both environments by commenting out the corresponding function calls. Additionally, in the development environment, there has been an update to set a bridge completion delay of 600, enhancing the bridge's operational timing. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
jonfung-dydx
approved these changes
Mar 27, 2024
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (2)
- protocol/testing/testnet-dev/dev.sh (1 hunks)
- protocol/testing/testnet-staging/staging.sh (1 hunks)
Additional comments: 3
protocol/testing/testnet-dev/dev.sh (2)
- 138-138: The
update_genesis_use_test_volatile_marketfunction call has been commented out as part of the PR objectives to temporarily disable the volatile market feature. This change aligns with the PR description.- 138-138: The
update_genesis_complete_bridge_delayfunction now sets a delay of 600, adjusting the bridge completion time. Ensure that this new delay value has been thoroughly tested and verified for its impact on the development testnet's operations.protocol/testing/testnet-staging/staging.sh (1)
- 192-192: The
update_genesis_use_test_volatile_marketfunction call has been commented out, consistent with the PR objectives to temporarily disable the volatile market feature for staging environments. This change is appropriate given the context.
Comment on lines
135
to
141
| # Using "@" as a subscript results in separate args: "dydx1..." "dydx1..." "dydx1..." | ||
| # Note: `edit_genesis` must be called before `add-genesis-account`. | ||
| edit_genesis "$VAL_CONFIG_DIR" "${TEST_ACCOUNTS[*]}" "${FAUCET_ACCOUNTS[*]}" "" "" "" "" | ||
| update_genesis_use_test_volatile_market "$VAL_CONFIG_DIR" | ||
| # update_genesis_use_test_volatile_market "$VAL_CONFIG_DIR" | ||
| update_genesis_complete_bridge_delay "$VAL_CONFIG_DIR" "600" | ||
|
|
||
| for acct in "${TEST_ACCOUNTS[@]}"; do |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [142-142]
It's recommended to double-quote variables in shell scripts to prevent globbing and word splitting. This applies to the usage of $USDC_DENOM and $NATIVE_TOKEN within the dydxprotocold add-genesis-account command.
- dydxprotocold add-genesis-account "$acct" 100000000000000000$USDC_DENOM,$TESTNET_VALIDATOR_NATIVE_TOKEN_BALANCE$NATIVE_TOKEN --home "$VAL_HOME_DIR"
+ dydxprotocold add-genesis-account "$acct" "100000000000000000$USDC_DENOM,$TESTNET_VALIDATOR_NATIVE_TOKEN_BALANCE$NATIVE_TOKEN" --home "$VAL_HOME_DIR"Also applies to: 145-145, 148-148
Comment on lines
189
to
195
| # Using "@" as a subscript results in separate args: "dydx1..." "dydx1..." "dydx1..." | ||
| # Note: `edit_genesis` must be called before `add-genesis-account`. | ||
| edit_genesis "$VAL_CONFIG_DIR" "${TEST_ACCOUNTS[*]}" "${FAUCET_ACCOUNTS[*]}" "" "" "" "" | ||
| update_genesis_use_test_volatile_market "$VAL_CONFIG_DIR" | ||
| # update_genesis_use_test_volatile_market "$VAL_CONFIG_DIR" | ||
| update_genesis_complete_bridge_delay "$VAL_CONFIG_DIR" "600" | ||
|
|
||
| for acct in "${TEST_ACCOUNTS[@]}"; do |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [196-196]
Similar to the dev.sh script, it's recommended to double-quote variables in shell scripts to prevent globbing and word splitting. This applies to the usage of $USDC_DENOM and $NATIVE_TOKEN within the dydxprotocold add-genesis-account command in the staging environment as well.
- dydxprotocold add-genesis-account "$acct" 100000000000000000$USDC_DENOM,$TESTNET_VALIDATOR_NATIVE_TOKEN_BALANCE$NATIVE_TOKEN --home "$VAL_HOME_DIR"
+ dydxprotocold add-genesis-account "$acct" "100000000000000000$USDC_DENOM,$TESTNET_VALIDATOR_NATIVE_TOKEN_BALANCE$NATIVE_TOKEN" --home "$VAL_HOME_DIR"Also applies to: 199-199, 202-202
Christopher-Li
approved these changes
Mar 29, 2024
Christopher-Li
pushed a commit
that referenced
this pull request
Mar 29, 2024
teddyding
pushed a commit
that referenced
this pull request
Mar 29, 2024
dydxwill
added a commit
that referenced
this pull request
Apr 3, 2024
* Add subaccountNumber to PerpetualPositionResponseObject (#1274) Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange> * [CT-712] send updates for both normal order matches and liquidation (#1280) * Remove volatile market (#1263) * [SKI-21] Bump slinky version to v0.3.1 (#1275) * Bump slinky version * Add cp number method * clean up socks logging (#1285) * [CT-681] fix liquidated side and offsetting side for indexer delevera… (#1284) * [CT-681] fix liquidated side and offsetting side for indexer deleveraging events * fix test * fix test * fix lint * [TRA-105] Add API for parent subaccount perpetual positions (#1282) Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange> * Use sample rate with stream destroyed stats. (#1294) * Revert "[CT-708] Indexer track e2e latency (#1237)" (#1292) This reverts commit 60b94df. * Fix swagger generation makefile command / regen swagger docs (#1299) * pull dydx fork to generate swagger properly * remove the print * remove vault constants (#1293) * Remove custom ping message from socks (#1301) * Add subaccountNumber to the OrderResponseObject (#1296) Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange> * sample more metrics (#1304) * [OTE-256] Add upgrade handler to initialize OI during upgrade handler (#1302) * Add upgrade handler to initialize OI during upgrade handler * nits * Fix lib.ErrorLogWithError: properly pass in args (#1306) * fix broken tests (#1312) * Explicitly close websockets on errors (#1290) * Increase the number of allowed connections to 8000 (#1317) * [TRA-104] Add parentSubaccountNumber API for orders (#1313) Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange> * Improve Slinky logs to prevent unnecessary logs (#1289) * [SKI-26]: Prevent funding index update with no oracle prices from (#1321) halting indexer * Skip equity tier limit check in PlaceShortTermOrder (#1318) * Skip equity tier limit check in PlaceShortTermOrder * remove tests * Add comment * fix lint (#1323) --------- Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange> Co-authored-by: shrenujb <98204323+shrenujb@users.noreply.github.com> Co-authored-by: jayy04 <103467857+jayy04@users.noreply.github.com> Co-authored-by: Eric Warehime <eric.warehime@gmail.com> Co-authored-by: vincentwschau <99756290+vincentwschau@users.noreply.github.com> Co-authored-by: Jonathan Fung <121899091+jonfung-dydx@users.noreply.github.com> Co-authored-by: Tian <tian@dydx.exchange> Co-authored-by: Teddy Ding <teddy@dydx.exchange> Co-authored-by: roy-dydx <133032749+roy-dydx@users.noreply.github.com> Co-authored-by: Christopher-Li <Christopher-Li@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Removes volatile market from dev/staging/local testnets. Will be re-enabled at a later time when Slinky supports it.
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.