Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upgrade handler for v5.1.0 #1836

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Add upgrade handler for v5.1.0 #1836

merged 4 commits into from
Jul 3, 2024

Conversation

vincentwschau
Copy link
Contributor

Changelist

Add upgrade handler for v5.1.0.

Test Plan

Updated container test, also tested upgrading from v5.0.5 in staging.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 2, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

vincentwschau
vincentwschau commented Jul 3, 2024
View reviewed changes
protocol/app/upgrades/v5.1.0/upgrade_container_test.go
@@ -0,0 +1,187 @@
//go:build all || container_test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in state to test after the upgrade, just an empty test to run the upgrade.

vincentwschau
vincentwschau commented Jul 3, 2024
View reviewed changes
protocol/app/upgrades/v5.1.0/upgrade_container_test.go Outdated
// Add test for your upgrade handler logic below
}

func placeOrders(node *containertest.Node, t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from previous upgrade test to sanity check network is running.

teddyding
teddyding reviewed Jul 3, 2024
View reviewed changes
protocol/app/upgrades/v5.0.0/upgrade_container_test.go
CarlDaveETHQuantums = 4_000_000
)

func TestStateUpgrade(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding, why do we need to delete this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs using the same container test setup I think, and will break since we're setting it up for a 5.0.5 to 5.1.0 upgrade and not a 4.0.0 to 5.0.0 upgrade.

@teddyding
Copy link
Contributor

For documentation purpose, should we frontport the v5.1.0 upgrade handler to main branch? So that the upgrade path is always clear.

@vincentwschau
Copy link
Contributor Author

We can front-port it, I'll set that up afterwards.

@vincentwschau vincentwschau merged commit 7aa0952 into release/protocol/v5.1.x Jul 3, 2024
18 checks passed
@vincentwschau vincentwschau deleted the vincentc/add-5-1-upgrade-handler branch July 3, 2024 03:31
@vincentwschau
Copy link
Contributor Author

@Mergifyio backport main

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024 •
edited
Loading

backport main

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 3, 2024
@vincentwschau @mergify
Add upgrade handler for v5.1.0 (#1836)
9bcc743 
(cherry picked from commit 7aa0952)

# Conflicts:
#	protocol/app/upgrades.go
#	protocol/testing/containertest/containertest.sh
#	protocol/testing/containertest/preupgrade_genesis.json
#	protocol/testing/containertest/testnet.go
@mergify mergify bot mentioned this pull request Jul 3, 2024
Closed
6 tasks
vincentwschau added a commit that referenced this pull request Jul 5, 2024
@vincentwschau
Add upgrade handler for v5.1.0 (#1836)
0c3af0c 
(cherry picked from commit 7aa0952)

# Conflicts:
#	protocol/app/upgrades.go
#	protocol/testing/containertest/containertest.sh
#	protocol/testing/containertest/preupgrade_genesis.json
#	protocol/testing/containertest/testnet.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddyding teddyding teddyding approved these changes

Assignees
No one assigned
Labels
protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentwschau @teddyding