remove panic when getting quantums from zero position #1964
Conversation
WalkthroughThe recent changes enhance error handling in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- protocol/x/subaccounts/types/position_size.go (3 hunks)
- protocol/x/subaccounts/types/position_size_test.go (3 hunks)
Additional comments not posted (17)
protocol/x/subaccounts/types/position_size_test.go (5)
Line range hint
10-20:
LGTM!The
TestGetBigQuantumsfunction covers positive, negative, and nil positions effectively.
45-46: LGTM!The changes to
TestPerpetualPosition_GetIsLongalign with the updated behavior of theGetIsLongmethod, ensuring it returnsFalseforzeroPositioninstead of panicking.
71-72: LGTM!The changes to
TestAssetPosition_GetIsLongalign with the updated behavior of theGetIsLongmethod, ensuring it returnsFalseforzeroPositioninstead of panicking.
Line range hint
78-87:
LGTM!The
TestAssetUpdate_GetIsLongfunction is well-written and covers edge cases effectively.
Line range hint
92-101:
LGTM!The
TestPerpetualUpdate_GetIsLongfunction is well-written and covers edge cases effectively.protocol/x/subaccounts/types/position_size.go (12)
42-44: LGTM!The
GetIdfunction forAssetPositionis straightforward and correct.
44-48: LGTM!The changes to
GetBigQuantumsforAssetPositionenhance robustness by handling nil positions and nil quantums gracefully.
Line range hint
50-54:
LGTM!The
GetIsLongfunction forAssetPositionis straightforward and correct.
Line range hint
56-58:
LGTM!The
GetIdfunction forPerpetualPositionis straightforward and correct.
Line range hint
60-62:
LGTM!The
SetQuantumsfunction forPerpetualPositionis straightforward and correct.
68-72: LGTM!The changes to
GetBigQuantumsforPerpetualPositionenhance robustness by handling nil positions and nil quantums gracefully.
Line range hint
74-78:
LGTM!The
GetQuoteBalancefunction forPerpetualPositionis straightforward and correct.
Line range hint
80-84:
LGTM!The
GetIsLongfunction forPerpetualPositionis straightforward and correct.
Line range hint
86-88:
LGTM!The
GetIsLongfunction forAssetUpdateis straightforward and correct.
Line range hint
90-92:
LGTM!The
GetBigQuantumsfunction forAssetUpdateis straightforward and correct.
Line range hint
94-98:
LGTM!The
GetBigQuoteBalancefunction forPerpetualUpdateis straightforward and correct.
Line range hint
106-108:
LGTM!The
GetIsLongfunction forPerpetualUpdateis straightforward and correct.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- protocol/x/subaccounts/lib/updates.go (1 hunks)
Additional comments not posted (1)
protocol/x/subaccounts/lib/updates.go (1)
61-61: Ensure theQuoteBalancefield is correctly handled.The new
QuoteBalancefield has been added to thePerpetualPositionstruct. Ensure that this field is correctly populated and used in downstream logic.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- protocol/x/subaccounts/types/genesis_test.go (3 hunks)
Additional comments not posted (2)
protocol/x/subaccounts/types/genesis_test.go (2)
174-175: LGTM! The change aligns with the PR objective.The
shouldPanicflag is correctly set tofalsefor the test case "invalid: asset position quantum == 0", indicating that the function should handle this case without panicking.
223-224: LGTM! The change aligns with the PR objective.The
shouldPanicflag is correctly set tofalsefor the test case "invalid: perpetual position quantum == 0", indicating that the function should handle this case without panicking.
Changelist
[Describe or list the changes made in this PR]
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
New Features
QuoteBalanceattribute.Bug Fixes
GetBigQuantumsmethod to prevent abrupt terminations, enhancing system robustness.GetIsLongmethod to provide a boolean return value for zero quantum positions instead of causing a panic.