Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cosmos SDK version #2064

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Bump Cosmos SDK version #2064

merged 1 commit into from
Aug 8, 2024

Conversation

teddyding
Copy link
Contributor

@teddyding teddyding commented Aug 8, 2024

Changelist

Bump Cosmos-SDK to this commit. Includes minor fix for OE and dependency package version update.

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Updated the app to leverage improvements and potential bug fixes from a newer version of the dYdX fork of the Cosmos SDK.
  • Bug Fixes

    • Enhanced performance and stability through dependency updates.

Copy link
Contributor

coderabbitai bot commented Aug 8, 2024

Walkthrough

This update to the Go module protocol/go.mod signifies a key improvement through the upgrade of the github.com/dydxprotocol/cosmos-sdk package to a more recent commit. This modification is likely to bring enhanced features and fixes from the dYdX fork of the Cosmos SDK while leaving other dependencies intact, marking a positive evolution in the project's stability and capabilities.

Changes

File Change Summary
protocol/go.mod Updated github.com/dydxprotocol/cosmos-sdk from v0.50.6-0.20240718235931-57faa863ce9a to v0.50.6-0.20240808180557-4b1c1dc17703.

Poem

🐇 In the meadow of code, we hop and play,
A new version blooms, brightening the day!
With each small tweak, our project takes flight,
Bugs flee in fear, all things feel right.
So here's to the changes, a joyful cheer,
For progress in code, let’s all hop near! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@teddyding
Copy link
Contributor Author

@mergify backport release/protocol/v6.x

Copy link
Contributor

mergify bot commented Aug 8, 2024

backport release/protocol/v6.x

✅ Backports have been created

@teddyding teddyding marked this pull request as ready for review August 8, 2024 18:39
@jonfung-dydx jonfung-dydx self-requested a review August 8, 2024 18:39
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ac64d4a and f22a6f1.

Files ignored due to path filters (1)
  • protocol/go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • protocol/go.mod (1 hunks)
Additional comments not posted (1)
protocol/go.mod (1)

471-471: Verify the impact of the updated cosmos-sdk dependency.

The github.com/dydxprotocol/cosmos-sdk dependency has been updated to a newer commit. Ensure that this update does not introduce any breaking changes or compatibility issues in the codebase.

Verification successful

No breaking changes detected in the updated cosmos-sdk dependency.

The specific paths referenced in the codebase have not changed in the updated version of the cosmos-sdk. This suggests that the update does not introduce any breaking changes or compatibility issues related to those paths.

  • No changes detected in x/auth/simulation/genesis.go.
  • No changes detected in x/auth/keeper/keeper.go.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the updated `cosmos-sdk` dependency.

# Test: Check for breaking changes or compatibility issues. Expect: No issues found.
rg --type go 'github.com/dydxprotocol/cosmos-sdk' --context 5

Length of output: 4912


Script:

#!/bin/bash
# Description: Check for changes in the specific paths or logic within the `cosmos-sdk` that are referenced in the codebase.

# List the specific paths in the `cosmos-sdk` that are referenced in the codebase
paths=(
  "x/auth/simulation/genesis.go"
  "x/auth/keeper/keeper.go"
)

# Check for changes in these paths in the `cosmos-sdk` repository
for path in "${paths[@]}"; do
  echo "Checking changes in $path..."
  git diff --name-only HEAD~1 HEAD -- "$path"
done

Length of output: 467

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f22a6f1 and fd39d31.

Files ignored due to path filters (1)
  • protocol/go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • protocol/go.mod (1 hunks)
Files skipped from review due to trivial changes (1)
  • protocol/go.mod

@teddyding teddyding merged commit 651bfbb into main Aug 8, 2024
17 of 18 checks passed
@teddyding teddyding deleted the td/bump-sdk branch August 8, 2024 21:22
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
(cherry picked from commit 651bfbb)
@mergify mergify bot mentioned this pull request Aug 8, 2024
6 tasks
teddyding added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: Teddy Ding <teddy@dydx.exchange>
@coderabbitai coderabbitai bot mentioned this pull request Sep 27, 2024
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 22, 2024
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 6, 2024
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 20, 2024
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants