Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add EIGEN,BOME as isolatd market in default test genesis (backport #2651) #2658

Merged
merged 3 commits into from
Dec 16, 2024
Merged

chore: Add EIGEN,BOME as isolatd market in default test genesis (backport #2651) #2658

merged 3 commits into from
Dec 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2024

Changelist

Copied over EIGEN,BOME params from prod

Test Plan

Tested on localnet

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Introduced new perpetual markets: "EIGEN-USD" and "BOME-USD" with updated configurations.
    • Enhanced logging in the pregenesis script for better user feedback during execution.

  • Bug Fixes

    • Removed strict sequential ID checks for ClobPair and Perpetual entries, simplifying validation processes.

  • Documentation

    • Updated app version from "7.0.0-dev0-129-g2b9a6b6dd" to "7.0.0-dev0-149-g12cfb908b".

  • Tests

    • Removed test cases related to gaps in ClobPair and Perpetual IDs, focusing on other validation aspects.
This is an automatic backport of pull request #2651 done by [Mergify](https://mergify.com).

@teddyding @mergify
chore: Add EIGEN,BOME as isolatd market in default test genesis (#2651)
254f317 
(cherry picked from commit 7117942)

# Conflicts:
#	protocol/scripts/genesis/sample_pregenesis.json
@mergify mergify bot requested a review from a team as a code owner December 13, 2024 14:57
@mergify mergify bot added the conflicts label Dec 13, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Dec 13, 2024

Cherry-pick of 7117942 has failed:

On branch mergify/bp/release/protocol/v7.x/pr-2651
Your branch is up to date with 'origin/release/protocol/v7.x'.

You are currently cherry-picking commit 7117942b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   protocol/scripts/genesis/prod_pregenesis.sh
	modified:   protocol/testing/genesis.sh
	modified:   protocol/x/clob/types/genesis.go
	modified:   protocol/x/clob/types/genesis_test.go
	modified:   protocol/x/perpetuals/types/genesis.go
	modified:   protocol/x/perpetuals/types/genesis_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   protocol/scripts/genesis/sample_pregenesis.json

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Dec 13, 2024
Merged
6 tasks
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

chenyaoy
chenyaoy reviewed Dec 13, 2024
View reviewed changes
protocol/scripts/genesis/sample_pregenesis.json Outdated
"app_version": "5.2.1-172-g351fcccd",
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

chenyaoy
chenyaoy reviewed Dec 13, 2024
View reviewed changes
protocol/scripts/genesis/prod_pregenesis.sh
edit_genesis "$VAL_CONFIG_DIR" "" "" "" "" "$TMP_EXCHANGE_CONFIG_JSON_DIR" "./testing/delaymsg_config" "STATUS_INITIALIZING" ""

echo "Oerwriting genesis params for production..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo Oerwriting

@teddyding teddyding merged commit a53b7c7 into release/protocol/v7.x Dec 16, 2024
24 checks passed
@teddyding teddyding deleted the mergify/bp/release/protocol/v7.x/pr-2651 branch December 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddyding teddyding teddyding approved these changes

@chenyaoy chenyaoy chenyaoy approved these changes

Assignees

@teddyding teddyding

Labels
protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenyaoy @teddyding