MOB-516 Add NavigatePage event

v4/core/src/main/java/exchange/dydx/trading/TradingActivity.kt

@@ -31,6 +31,7 @@ import exchange.dydx.trading.core.DydxNavGraph
 import exchange.dydx.trading.core.biometric.DydxBiometricPrompt
 import exchange.dydx.trading.core.biometric.DydxBiometricView
 import exchange.dydx.trading.feature.shared.PreferenceKeys
+import exchange.dydx.trading.feature.shared.analytics.AnalyticsEvent
 import exchange.dydx.utilities.utils.SharedPreferencesStore
 import kotlinx.coroutines.launch
 import javax.inject.Inject
@@ -61,6 +62,11 @@ class TradingActivity : FragmentActivity() {
         CarteraSetup.run(this, viewModel.logger)
         AnalyticsSetup.run(viewModel.compositeTracking, this, viewModel.logger)
 
+        viewModel.compositeTracking.log(
+            event = AnalyticsEvent.APP_START.rawValue,
+            data = null,
+        )
+
         WindowCompat.setDecorFitsSystemWindows(window, false)
 
         lifecycleScope.launch {

v4/core/src/main/java/exchange/dydx/trading/core/DydxRouterImpl.kt

@@ -15,6 +15,7 @@ import exchange.dydx.trading.common.AppConfig
 import exchange.dydx.trading.common.navigation.DydxRouter
 import exchange.dydx.trading.common.navigation.DydxRouter.Destination
 import exchange.dydx.trading.common.navigation.MarketRoutes
+import exchange.dydx.trading.feature.shared.analytics.RoutingAnalytics
 import exchange.dydx.trading.integration.analytics.tracking.Tracking
 import exchange.dydx.utilities.utils.Logging
 import kotlinx.coroutines.flow.MutableStateFlow
@@ -35,6 +36,7 @@ class DydxRouterImpl @Inject constructor(
     private val tracker: Tracking,
     appConfig: AppConfig,
     private val logger: Logging,
+    private val routingAnalytics: RoutingAnalytics,
 ) : DydxRouter {
 
     private lateinit var navHostController: NavHostController
@@ -85,7 +87,7 @@ class DydxRouterImpl @Inject constructor(
 
             val destinationRoute = destination.route
             if (destinationRoute != null) {
-                trackRoute(destinationRoute, destination, arguments)
+                routingAnalytics.logRoute(destinationRoute, arguments)
 
                 if (tabRoutes.contains(destinationRoute)) {
                     routeQueue.clear()
@@ -220,24 +222,4 @@ class DydxRouterImpl @Inject constructor(
         }
         return route
     }
-
-    private fun trackRoute(destinationRoute: String, destination: NavDestination, arguments: Bundle?) {
-        val trackingData: MutableMap<String, String> = mutableMapOf()
-        destination.arguments.keys.forEach { key ->
-            trackingData[key] = arguments?.getString(key) ?: ""
-        }
-        // Remove query parameters from the route and remove the last component if it's a dynamic route
-        var sanitizedRoute = destinationRoute.split("?").first()
-        val components = sanitizedRoute.split("/")
-        val lastComponent = components.last()
-        if (lastComponent.startsWith("{") && lastComponent.endsWith("}")) {
-            sanitizedRoute = components.dropLast(1).joinToString("_")
-        } else {
-            sanitizedRoute = components.joinToString("_")
-        }
-        tracker.log(
-            event = sanitizedRoute,
-            data = trackingData,
-        )
-    }
 }

v4/feature/shared/src/main/java/exchange/dydx/trading/feature/shared/analytics/RoutingAnalytics.kt

@@ -0,0 +1,41 @@
+package exchange.dydx.trading.feature.shared.analytics
+
+import android.os.Bundle
+import exchange.dydx.trading.integration.analytics.tracking.Tracking
+import javax.inject.Inject
+import javax.inject.Singleton
+
+@Singleton
+class RoutingAnalytics @Inject constructor(
+    private val tracker: Tracking,
+) {
+    fun logRoute(
+        destinationRoute: String,
+        arguments: Bundle?
+    ) {
+        var pathWithArguments = destinationRoute
+        if (pathWithArguments.startsWith("market/{marketId}")) {
+            // web does not have a /market/<MARKET> path
+            pathWithArguments = pathWithArguments.replace("market/{marketId}", "trade/{marketId}")
+        }
+        arguments?.keySet()?.forEach { key ->
+            pathWithArguments = pathWithArguments.replace("{$key}", arguments.getString(key) ?: "")
+        }
+        if (!pathWithArguments.startsWith("/")) {
+            // Android routes don't start with "/"
+            pathWithArguments = "/$pathWithArguments"
+        }
+
+        tracker.view(
+            screenName = pathWithArguments,
+            screenClass = "TradingActivity",
+        )
+
+        tracker.log(
+            event = AnalyticsEvent.NAVIGATE_PAGE.rawValue,
+            data = mapOf(
+                "path" to pathWithArguments,
+            ),
+        )
+    }
+}

v4/integration/analytics/src/main/java/exchange/dydx/trading/integration/analytics/tracking/AmplitudeTracker.kt

@@ -27,4 +27,8 @@ class AmplitudeTracker(
         val jsonMap = data?.jsonStringToMap()
         amplitude.track(event, jsonMap)
     }
+
+    override fun view(screenName: String, screenClass: String) {
+        // No op
+    }
 }

v4/integration/analytics/src/main/java/exchange/dydx/trading/integration/analytics/tracking/CompositeTracker.kt

@@ -26,4 +26,8 @@ class CompositeTracker @Inject constructor() : CompositeTracking {
     override fun log(event: String, data: String?) {
         trackers.forEach { it.log(event, data) }
     }
+
+    override fun view(screenName: String, screenClass: String) {
+        trackers.forEach { it.view(screenName, screenClass) }
+    }
 }

v4/integration/analytics/src/main/java/exchange/dydx/trading/integration/analytics/tracking/FirebaseTracker.kt

@@ -26,4 +26,11 @@ class FirebaseTracker(
             }
         }
     }
+
+    override fun view(screenName: String, screenClass: String) {
+        firebaseAnalytics.logEvent(FirebaseAnalytics.Event.SCREEN_VIEW) {
+            param(FirebaseAnalytics.Param.SCREEN_NAME, screenName)
+            param(FirebaseAnalytics.Param.SCREEN_CLASS, screenClass)
+        }
+    }
 }

v4/integration/analytics/src/main/java/exchange/dydx/trading/integration/analytics/tracking/Tracking.kt

@@ -2,6 +2,7 @@ package exchange.dydx.trading.integration.analytics.tracking
 
 import exchange.dydx.abacus.protocols.TrackingProtocol
 import exchange.dydx.abacus.utils.toJson
+import exchange.dydx.trading.common.AsyncResult.Waiting.data
 
 interface Tracking : TrackingProtocol {
 
@@ -14,6 +15,8 @@ interface Tracking : TrackingProtocol {
     fun log(event: String, data: Map<String, Any?>) {
         log(event, data.toJson())
     }
+
+    fun view(screenName: String, screenClass: String)
 }
 
 interface CompositeTracking : Tracking {