Convert AsyncStep to suspending functions instead of Flows #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanDYDX
force-pushed
the
prashan/convert-async-step-suspend
branch
from
884e09e
to
0417b6d
Compare
prashanDYDX
changed the title
ruixhuang
approved these changes
Aug 13, 2024
prashanDYDX
force-pushed
the
prashan/convert-async-step-suspend
branch
from
2c6a017
to
87b4cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since AsyncSteps are meant to be executed only once and we do not seem to use the
Progressstate for anything, it is far simpler / readable to express them as suspending functions.This PR also adds some logging to AsyncStep and removes EthGetNonceStep (as discussed in t-clients)
Tested working with both MetaMask and Trust.