Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push fixes #230

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Push fixes #230

merged 2 commits into from
Sep 27, 2024

Conversation

prashanDYDX
Copy link
Contributor

Bunch of changes:

  • Refactor workers to be injected
  • Move push token registration from service start to app start (i thought services were started on app start, but they are only launched as needed in response to incoming messages)
  • Disable primer. I tried a bunch of different ways to get this to work, but something about the Trade UI is stumping me, using PlatformDialogScaffold doesn't seem to work. Might look at this later if I have more time.
  • Filter out Abacus notifications.

ruixhuang
ruixhuang reviewed Sep 27, 2024
View reviewed changes
...n/fcm/src/main/java/exchange/dydx/trading/integration/fcm/PushPermissionRequesterProtocol.kt
confirmAction = ::request,
)

// this currently doesn't work, leaving here to figure out later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work when calling from the view model?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ultimately gets called from the viewmodel anyways.

i think it's a layout issue with AlertDialog and BottomSheetScaffold

@prashanDYDX prashanDYDX merged commit 30eecb5 into develop Sep 27, 2024
5 checks passed
@prashanDYDX prashanDYDX deleted the prashan/push-fixes branch September 27, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruixhuang ruixhuang ruixhuang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashanDYDX @ruixhuang