fix: just merge vault pnl points for smooth recent pnl plus long term views #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
seems fine |
tinaszheng
approved these changes
Oct 16, 2024
tinaszheng
reviewed
Oct 16, 2024
| const getMegavaultHistoricalPnl = useCallback( | ||
| async (resolution: PnlTickInterval = PnlTickInterval.day) => { | ||
| try { | ||
| return await indexerClient.vault.getMegavaultHistoricalPnl(resolution); |
There was a problem hiding this comment.
why not just wrap this with VaultCalculator.getVaultHistoricalPnlResponse(safeStringifyForAbacusParsing(res)); here
There was a problem hiding this comment.
We could, but the vibe in useDydxClient is generally it's only wrapping client calls and returning untyped garbage so I followed that convention. Not sure why it's that way though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to hold off merging until staging pnl points are fixed so I can see how this actually looks.