Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(abacus-metadata): bump abacus and update asset usage #1149

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Oct 15, 2024

Use updated Abacus version for metadata service.


Views

  • <HeaderDesktop>
    • Remove launch market links

Components

  • <MarketTableCell>

    • use asset resource logo url
  • <AssetIcon>

    • Add fallback if logoUrl fails

Constants/Types

  • constants/assets

    • Move asset icon mapping to constants
  • constants/markets

    • Add DEPIN filter and update all filters to match CMC sector tags

Hooks

  • hooks/useMarketsData
    • Update filter functions for markets to respect CMC sector tags

Lib

  • lib/abacus

    • set MetadataService flag to true for Abacus configs
  • lib/testFlags

    • show PML in dev envs

Packages

  • v4-abacus
    • MetadataService compatible
    • updated: v1.12.23 -> v1.12.26

@jaredvu jaredvu requested a review from a team as a code owner October 15, 2024 22:43
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 5:08pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 5:08pm

MEME = 'Meme',
RWA = 'RWA',
ENT = 'Entertainment',
FX = 'fiat',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] is this data coming from abacus? curious as to why we're updating most of these enum k/v pairs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data is coming back from Abacus after it fetches from the metadata service. I re-added the old tags so we don't have any compatibility issues when using configs/markets.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope yeah i was slightly concerned about that. thanks man!

@jaredvu jaredvu merged commit 1f629a1 into main Oct 17, 2024
9 checks passed
@jaredvu jaredvu deleted the jv/abacus-metadataservice branch October 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants