chore: gate ohlc behind statsig ff #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moo-onthelawn
commented
Oct 17, 2024
| @@ -28,7 +28,7 @@ class AbacusWebsocket implements Omit<AbacusWebsocketProtocol, '__doNotUseOrImpl | |||
|
|
|||
| private isConnecting: boolean = false; | |||
|
|
|||
| orderbookCandlesToggleOn: boolean = true; | |||
| orderbookCandlesToggleOn: boolean = false; | |||
There was a problem hiding this comment.
this line is fine and can stay this way even after we remove the flag/set it to true since this line handles syncing it with FE state on mount
aforaleka
approved these changes
Oct 17, 2024
moo-onthelawn
deleted the
mulan/ct-1299-add-statsig-for-turning-ohlc-onoff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gates ohlc behind statsig ff (ff_enable_ohlc) because we foresee needing to turn it on/off a few times in the next few weeks.
Expected behavior:
Tested by toggling ff_enable_ohlc and verifying the above cases (i suggest using NOT market to see obvious differences)