Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix button styling nits #1186

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix: fix button styling nits #1186

merged 3 commits into from
Oct 21, 2024

Conversation

moo-onthelawn
Copy link
Contributor

@moo-onthelawn moo-onthelawn commented Oct 21, 2024

follow ups from #1178 (comment) and consolidated styling of IconButton and Button

Screenshot 2024-10-21 at 2 17 01 PM Screenshot 2024-10-21 at 2 14 27 PM Screenshot 2024-10-21 at 12 56 38 PM Screenshot 2024-10-21 at 12 56 09 PM Screenshot 2024-10-21 at 2 40 41 PM

Views

  • <ClosePositionForm>

    • Wrap text in span so that tag is properly positioned after it
  • <OrderActionsCell>

    • Replaced $uiRefreshEnabled styling with buttonStyle prop
    • Fixed width so that the focus looks correct
  • <PositionActionsCell>

    • Replaced $uiRefreshEnabled styling with buttonStyle prop
    • Fixed width so that the focus looks correct
    • Reduced icon size a bit, checked with both flag on and off
  • <PositionTriggersCell>

    • Fixed width so that the focus looks correct

Components

  • <CollapsibleTabs>

    • Update to Square when uiRefresh enabled so that focus outlines match
    • Replaced $uiRefreshEnabled styling with IconButton prop
  • <IconButton>

    • Replaced withoutBackground styleprop with buttonStyle style prop to match Button props
  • <WithTooltip>

    • Allow caller to override sideOffset

@moo-onthelawn moo-onthelawn requested a review from a team as a code owner October 21, 2024 18:31
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 6:58pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 6:58pm

@moo-onthelawn moo-onthelawn merged commit c768b35 into main Oct 21, 2024
7 checks passed
@moo-onthelawn moo-onthelawn deleted the mulan-followUpNits branch October 21, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants