Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uirefresh): component refresh - collapsible receipt #1190

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

moo-onthelawn
Copy link
Contributor

@moo-onthelawn moo-onthelawn commented Oct 22, 2024

I tried to animate the collapse but it was giving me some weird jumpy things due to the parent flex positioning. Decided that for now it's more work than it's worth, but happy to follow up post launch!

  • Will follow up in separate task to auto collapse receipt when screen is short enough
receiptFlag.mov

Views

  • ClosePositionForm, TradeForm
    • Use updated PlaceOrderButtonAndReceipt component

Components

  • DropdownSelectMenu

    • Replace triangle icon dropdown with caret when uiRefresh enabled
  • Icon

    • Clean up props
  • Tabs

    • Don't override default 0.5ch gap from tabTriggerStyle
  • WithReceipt

    • Nothing really changed - just changed implementation to show/hide from opacity/height to grid-template-rows. Ideally was trying to animate via grid template rows but didn't look great due to parent flex height (instead of fixed). Kept around to make it easier to animate later
  • PlaceOrderButtonAndReceipt

    • Bundle in the Clear and HideReceipt buttons into this component
    • Add HideButton only when uiRefresh enabled

Packages

  • v4-localization

Copy link

linear bot commented Oct 22, 2024

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 3:37pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 3:37pm

Copy link
Contributor

@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable but I don't really get why we want this

@moo-onthelawn
Copy link
Contributor Author

seems reasonable but I don't really get why we want this

ah it's cuz on smaller screens (i.e. 14 inch macbook) the trade form bar can feel really short + tight when our receipt takes up 50% of the space

@moo-onthelawn moo-onthelawn merged commit 723a33f into main Oct 22, 2024
15 checks passed
@moo-onthelawn moo-onthelawn deleted the mulan/ct-1284-make-receipt-collapsible branch October 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants