Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc vault fixes 6 #1208

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: misc vault fixes 6 #1208

merged 1 commit into from
Oct 23, 2024

Conversation

tyleroooo
Copy link
Contributor

No description provided.

@tyleroooo tyleroooo requested a review from a team as a code owner October 23, 2024 19:19
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 7:23pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 7:23pm

Comment on lines -90 to -91
// todo add to the link configs objects
vaultsLearnMore: linksConfigs.vaultsLearnMore ?? FALLBACK_URL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need vaultLearnMore since we are deprecating vaultsLearnMore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there!

@tyleroooo tyleroooo merged commit 5574b5c into main Oct 23, 2024
9 checks passed
@tyleroooo tyleroooo deleted the tu/misc-vault-fixes-6 branch October 23, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants