chore: separating app UI configs slice #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aforaleka
force-pushed
the
separating-app-ui-configs-slice
branch
from
b4e16b8
to
7b161b5
Compare
jaredvu
reviewed
Oct 24, 2024
jaredvu
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Overall looks good to me! Will let @tinaszheng comment on redux-persist
tyleroooo
approved these changes
Oct 24, 2024
aforaleka
force-pushed
the
separating-app-ui-configs-slice
branch
from
38f4284
to
2d34d6a
Compare
tyleroooo
approved these changes
Oct 24, 2024
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate ui configs from configs slice, and run migration to redux persist
testing: