Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc vault fixes 7 #1216

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix: misc vault fixes 7 #1216

merged 2 commits into from
Oct 24, 2024

Conversation

tyleroooo
Copy link
Contributor

KEEP THE MISC FIXES TRAIN GOING

@tyleroooo tyleroooo requested a review from a team as a code owner October 24, 2024 17:51
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 6:01pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 6:01pm

(currentLeverageMultiple ?? 0) === 0
? stringGetter({ key: STRING_KEYS.NONE })
: (currentLeverageMultiple ?? 0) < 0
{(currentLeverageMultiple ?? 0) !== 0 && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this different from
!!currentLeverageMultiple? since what we're doing here is having nully values convert to 0, which then evaluate to false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true that works too, I will do that

Copy link
Contributor

@yogurtandjam yogurtandjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but have a q

@tyleroooo tyleroooo enabled auto-merge (squash) October 24, 2024 17:58
{!!currentLeverageMultiple && (
<$OutputSigned
value={
(currentLeverageMultiple ?? 0) < 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, is this conditional possible? since this won't render unless !!currentLEverageMultiple evaluates to true?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, what i meant is the nullish coalescing operator required*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good point it's not required anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welp guess it's going in the next misc fixes pr, probably tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants