-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: misc vault fixes 7 #1216
fix: misc vault fixes 7 #1216
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
(currentLeverageMultiple ?? 0) === 0 | ||
? stringGetter({ key: STRING_KEYS.NONE }) | ||
: (currentLeverageMultiple ?? 0) < 0 | ||
{(currentLeverageMultiple ?? 0) !== 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this different from
!!currentLeverageMultiple
? since what we're doing here is having nully values convert to 0, which then evaluate to false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true that works too, I will do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved but have a q
{!!currentLeverageMultiple && ( | ||
<$OutputSigned | ||
value={ | ||
(currentLeverageMultiple ?? 0) < 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, is this conditional possible? since this won't render unless !!currentLEverageMultiple
evaluates to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, what i meant is the nullish coalescing operator required*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh good point it's not required anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welp guess it's going in the next misc fixes pr, probably tomorrow
KEEP THE MISC FIXES TRAIN GOING