Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add an example of configuring wallets that show up in the walletconnect modal list #1384

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ruixhuang
Copy link
Contributor

This is completely optional. Adding this as an example for the deployer.

@ruixhuang ruixhuang requested a review from a team as a code owner December 19, 2024 03:20
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:21am
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:21am

@jaredvu jaredvu changed the title config: Add an example of configuring wallets that show up in the walletconnect modal list fix: Add an example of configuring wallets that show up in the walletconnect modal list Dec 19, 2024
@jaredvu jaredvu changed the title fix: Add an example of configuring wallets that show up in the walletconnect modal list chore: Add an example of configuring wallets that show up in the walletconnect modal list Dec 19, 2024
Copy link
Contributor

@jaredvu jaredvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruixhuang Should we add empty arrays for mainnet section?

@ruixhuang
Copy link
Contributor Author

@ruixhuang Should we add empty arrays for mainnet section?

Empty array would mean no wallet will be listed ;-)

@ruixhuang ruixhuang merged commit 82a2b4b into main Dec 19, 2024
10 of 11 checks passed
@ruixhuang ruixhuang deleted the feature/mobile_wc branch December 19, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants