chore(displayId): Migrate marketId rendering to displayId #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dit-usage-of-market-from
…dit-usage-of-market-from
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
is there a similar set of changes for asset ids? We display those in tags and things all over. |
assetIds were also changed in abacus. So instead of deriving the assetIds from marketId they are now derived from displayId |
…dit-usage-of-market-from
rosepuppy
approved these changes
Aug 26, 2024
jaredvu
deleted the
jared/tra-542-web-migrate-usage-of-id-and-audit-usage-of-market-from
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
marketIdusage withdisplayIdViews
<TradeHeaderMobile>displayIdinstead ofmarket<MarketSelectorAndStats>getCurrentMarketId->getCurrentMarketDisplayId<MarketDetails>/<FillDetailsDialog>/<OrderDetailsDialog>tickerrow to exposemarketId<PositionsTable>/<OrdersTable>displayIdfor<MarketTableCell>Hooks
hooks/useMarketsData/<Markets>State
state/perpetualsSelectorsgetCurrentMarketDisplayIdPackages
v4-abacusdisplayId